Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NTV-611] Optimizely Carthage Package -> SPM #1724

Merged
merged 4 commits into from Sep 12, 2022
Merged

[NTV-611] Optimizely Carthage Package -> SPM #1724

merged 4 commits into from Sep 12, 2022

Conversation

scottkicks
Copy link
Contributor

@scottkicks scottkicks commented Sep 8, 2022

📲 What

As part of our Carthage -> SPM migration we need to migrate Optimizely

🤔 Why

Checkout this Guru Card for more details

🛠 How

  • Remove the dependencies from Cartfile and Cartfile.resolved and add them to Package.resolved
  • Use minimum version 6.5.2
  • Resolve any merge conflicts

✅ Acceptance criteria

  • Breakpoint most instances of code used in files that import Optimizely and run the app on device to check the breakpoints are hit and the app continues to run as expected. Specifically in the Feature Flag viewer
  • Run app and smoke test where framework is supposed to be used.

@scottkicks scottkicks changed the title [NVT-611] Optimizely Carthage Package -> SPM [NTV-611] Optimizely Carthage Package -> SPM Sep 8, 2022
@scottkicks scottkicks self-assigned this Sep 8, 2022
@scottkicks scottkicks added this to the release-5.5.0 milestone Sep 8, 2022
@scottkicks scottkicks marked this pull request as ready for review September 12, 2022 14:45
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1724 (3b2e9eb) into main (f54d4a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1724   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files        1270     1270           
  Lines      114695   114695           
  Branches    30296    30296           
=======================================
+ Hits        97928    97930    +2     
+ Misses      15715    15713    -2     
  Partials     1052     1052           
Impacted Files Coverage Δ
...tarter-iOS/Library/OptimizelyResultTypeTests.swift 100.00% <100.00%> (ø)
Library/Navigation.swift 85.85% <0.00%> (+0.64%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@msadoon msadoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go!

@scottkicks scottkicks merged commit d5ce4d2 into main Sep 12, 2022
@scottkicks scottkicks deleted the nvt-611 branch September 12, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants