Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-742] Migrates PerimeterX to SPM #1734

Merged
merged 3 commits into from Sep 22, 2022
Merged

[WEB-742] Migrates PerimeterX to SPM #1734

merged 3 commits into from Sep 22, 2022

Conversation

scottkicks
Copy link
Contributor

@scottkicks scottkicks commented Sep 20, 2022

πŸ“² What

As part of our Carthage -> SPM migration we need to migrate PerimeterX

πŸ€” Why

Checkout this Guru Card for more details

πŸ›  How

  • Remove the dependencies from Cartfile and Cartfile.resolved and add them to KsApi target
  • Minimum version to 1.13.9
  • Resolve any merge conflicts

βœ… Acceptance criteria

  • Breakpoint most instances of code used in files that import PerimeterX (KsAPI Target) and run the app on device to check the breakpoints are hit and the app continues to run as expected..
  • Run/build app, smoke test, and verify that all tests pass.

@scottkicks scottkicks changed the title Migrates PerimeterX to SPM [WEB-742] Migrates PerimeterX to SPM Sep 20, 2022
@scottkicks scottkicks self-assigned this Sep 20, 2022
@scottkicks scottkicks added this to the release-5.5.0 milestone Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1734 (c8aa313) into main (e3cb02a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1734   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files        1275     1275           
  Lines      114938   114938           
  Branches    30377    30377           
=======================================
  Hits        98110    98110           
  Misses      15776    15776           
  Partials     1052     1052           

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@scottkicks scottkicks marked this pull request as ready for review September 21, 2022 18:25
Copy link
Contributor

@msadoon msadoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, good job, just remove it from the main Kickstarter-iOS app target. It only needs to be in KsAPI.

(Oddly though, it was never included in any of the targets when it was a binary but was still referenced somewhere)

Anyway, including it it only KsApi target is totally fine for now.

@scottkicks
Copy link
Contributor Author

(Oddly though, it was never included in any of the targets when it was a binary but was still referenced somewhere)

@msadoon Yea I noticed the same thing with the Appboy-iOS-SDK binary. Thanks i'll update the main target. I forgot that it gets cached there.

@scottkicks scottkicks merged commit 27d436a into main Sep 22, 2022
@scottkicks scottkicks deleted the web-742 branch September 22, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants