[WEB-740] Refactored AppBoySegment to SPM

[msadoon]

📲 What

Refactor of this pr so no code changes are required.

🤔 Why

Wanted to ensure we had as minimal code changes as necessary.

🛠 How

1. Removed github "appboy/appboy-segment-ios" == 4.0.0 from Cartfile and Cartfile.resolved
2. Removed Segment.framework and Segment_Appboy.framework from app-input-files app-output-files library-input-files library-output-files
3. Removed all dependencies from project.pbxproj

Build Phases - Link Binary With Libraries
Kickstarter-Framework-iOSTests
Segment_Appboy.framework

Library
Segment.framework
Segment_Appboy.framework

Library-iOSTests
Segment_Appboy.framework

Kickstarter-iOS
Segment.framework
Segment_Appboy.framework

Build Phases - Copy Files

Library-Framework-iOSTests
Segment.framework
Segment_Appboy.framework

Kickstarter-Framework-iOSTests
Segment.framework
Segment_Appboy.framework

4. Used https://github.com/Appboy/appboy-segment-ios in SPM, only pulled in AppboySegment not AppboySegmentCore.

5. Only added AppboySegment to Kickstarter-FrameworkiOS and Library, nowehere else.

6. Made minor import corrections in

AppDelegate, BrazeTypes, 
import Segment_Appboy --> import AppboySegment

KSRAnalytics
import Segment --> import AppboySegment

Segment
import Segment, import Segment_Appboy, import Appboy_iOS_SDK --> import AppboySegment

✅ Acceptance criteria

• See that segment events are still being sent
• Ensure Braze pn's and in-app messages are still working.

[codecov]

Codecov Report

Merging #1735 (cc22e06) into main (6c367db) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1735   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files        1270     1270           
  Lines      114842   114841    -1     
  Branches    30335    30335           
=======================================
  Hits        98028    98028           
+ Misses      15762    15761    -1     
  Partials     1052     1052           

Impacted Files	Coverage Δ
Library/Tracking/KSRAnalytics.swift	81.76% <ø> (ø)
Library/Tracking/Segment.swift	0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[msadoon]

crashing on launch on device, one sec, maybe this does require more code changes.

[msadoon]

crashing on launch on device, one sec, maybe this does require more code changes.

No longer issue, last commit resolves a weird threading issue and prevents duplicate configuration on Analytics

[scottkicks]

nice catch