Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unticketed] PerimeterX Beta Build 5.4.0 (16642229) Crash #1740

Merged
merged 2 commits into from Sep 27, 2022

Conversation

msadoon
Copy link
Contributor

@msadoon msadoon commented Sep 26, 2022

Turns out our last PerimeterX upgrade to SPM caused on device launch crash (beta build) because of @rpath/Library/PerimeterX.framework was not found. Although the only framework that referenced it with import PerimeterX was KsApi, the Library framework somehow needed it. Felt it safest to include within the library target as well until a more thorough investigation could be done.

@msadoon msadoon self-assigned this Sep 26, 2022
@msadoon msadoon added this to the release-5.5.0 milestone Sep 26, 2022
@msadoon msadoon changed the title [Unticketed] PerimeterX Beta Build Crash [Unticketed] PerimeterX Beta Build 5.4.0 (16642229) Crash Sep 26, 2022
Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! No idea how that didn't come up in my testing. can we create a ticket to investigate this further?

@msadoon msadoon merged commit 30e2c6f into main Sep 27, 2022
@msadoon msadoon deleted the fix/perimeterx-crash-fix branch September 27, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants