[PAY-2040] Payment Sheet Displayed On Unrelated Context

[msadoon]

📲 What and 🤔 Why

We want to prevent any janky behaviour with the payment sheet because it does take a moment to show and the user has the chance to back to the previous page in that time.

🛠 How

Check the view type before presenting but after creating the PaymentSheet.FlowController.

👀 See

Before 🐛

RPReplay_Final1666821573.MP4

After 🦋

RPReplay_Final1666822441.MP4

✅ Acceptance criteria

• Neither PledgeViewController or PaymentMethodsViewController show the payment sheet.

⏰ TODO

• Test both contexts > 10 times (tricky due to timing)

[codecov]

Codecov Report

Merging #1752 (4e664e2) into main (d954d24) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1752      +/-   ##
==========================================
- Coverage   85.38%   85.38%   -0.01%     
==========================================
  Files        1275     1275              
  Lines      115183   115189       +6     
  Branches    30455    30457       +2     
==========================================
  Hits        98350    98350              
- Misses      15779    15785       +6     
  Partials     1054     1054              

Impacted Files	Coverage Δ
...hods/Controller/PaymentMethodsViewController.swift	60.00% <0.00%> (-1.02%)	⬇️
...ontroller/PledgePaymentMethodsViewController.swift	45.51% <0.00%> (-0.97%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[scottkicks]

Tested and this is working as expected. Nice catch!

The instances of these ViewControllers are actually deallocated when going back to the previous screens most of the time. It's only in those very rare cases where the sheet's create completion makes it past those guard statements.

Took me a minute to actually time that right 😆 to see the bug! Just need to update this branch with main

[msadoon]

Tested and this is working as expected. Nice catch!

The instances of these ViewControllers are actually deallocated when going back to the previous screens most of the time. It's only in those very rare cases where the sheet's create completion makes it past those guard statements.

Took me a minute to actually time that right 😆 to see the bug! Just need to update this branch with main

Cool, thanks for the review, it is a timing issue, I didn't think it would matter given how rarely it happens but probably best to tighten up the logic a little. I updated the branch, there's an update branch with main button on the bottom right.