Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One pass availability reporting #176

Merged
merged 2 commits into from
Jun 7, 2017
Merged

Conversation

bormind
Copy link
Contributor

@bormind bormind commented Jun 7, 2017

replaced property 1password_extension_available with property one_password_extension_available for Viewed Login tracking event. Kept property 1password_extension_available for User Login event intact because it is marked as deprecated and will be removed..

Reference Trello card: Update 1password property

Copy link
Contributor

@theginbin theginbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Boris!

@justinswart
Copy link
Contributor

Nice Boris! Merge away 👍

@bormind bormind merged commit 480acc1 into master Jun 7, 2017
@bormind bormind deleted the one_pass_availability_reporting branch June 7, 2017 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants