[WEB-696] CTA Dialog on Facebook Login Error (FB Deprecation)

[scottkicks]

📲 What

As a User who does not have a Kickstarter password and attempts to log in via Facebook, but gets an error either from Facebook, we should present a CTA dialog on the login screen with options to set a new password or use normal email password login

See the designs for details on what this should look like.

Since we're still looking into the issue we're seeing around snapshot testing on M1 macbooks, I've created a ticket to get that part of this PR in once, Mubarak is back

🤔 Why

In the past FB has turned off their FB Login API without warning keeping kickstarters from logging in.
In an effort to deprecate FB Login altogether, this covers that scenario. Both informing the kickstarter that we need them to set a password or log in through our normal login flow.

This will allow us to ensure that everyone is more aware of the move away from FB Login as well as give everyone a chance to set a password on their accounts if they don't already have one.

🛠 How

• Created a new ResetYourFacebookPassword screen. Allows a kickstarter to get an email to set a password on their account. This is essentially the normal reset password flow.
• Created a new CTA popup with 2 options. Either navigate to normal log in or to the new screen.
• Using the showFacebookErrorAlert listener in LoginToutViewController, we can:
  1. Check to make sure that Facebook Login Deprecation flag is enabled
  2. Present this new CTA at the right time

👀 See

Trello, screenshots, external resources?

✅ Acceptance criteria

• If an error occurs when attempting to login with FB, and the FF is on, this new CTA shows
• The actions on the new CTA navigate to the correct screens
• The submit button on ResetYourFacebookPassword screen sends an email to the email, if valid, allowing you to set a password on your account.

[nativeksr]

	1 Warning
⚠️	Big PR

Generated by 🚫 Danger

[codecov]

Codecov Report

Merging #1763 (49e5ef6) into main (b936c69) will decrease coverage by 0.12%.
The diff coverage is 39.93%.

@@            Coverage Diff             @@
##             main    #1763      +/-   ##
==========================================
- Coverage   85.42%   85.29%   -0.13%     
==========================================
  Files        1273     1276       +3     
  Lines      116209   116541     +332     
  Branches    30637    30722      +85     
==========================================
+ Hits        99273    99408     +135     
- Misses      15869    16066     +197     
  Partials     1067     1067              

Impacted Files	Coverage Δ
...LoginTout/Controller/LoginToutViewController.swift	53.50% <0.00%> (-2.67%)	⬇️
...ller/ResetYourFacebookPasswordViewController.swift	0.00% <0.00%> (ø)
Library/UIAlertController.swift	0.73% <0.00%> (-0.07%)	⬇️
...iewModels/ResetYourFacebookPasswordViewModel.swift	96.29% <96.29%> (ø)
...dels/ResetYourFacebookPasswordViewModelTests.swift	100.00% <100.00%> (ø)
Library/Navigation.swift	85.85% <0.00%> (+0.64%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[msadoon]

Hey Scott, good job here! Works well, code is pretty clean.
I did a deeper review of this and found some improvements to make.

I didn't write it as a comment but can you also remove all the recorded screenshots here. I've made a note to record these in the fix screenshots pr so they are platform agnostic.

There's something else too which I know can be a chore, but would improve the accessibility and usability of the app for larger font sizes. It would also be more consistent with SignUpViewController and other form fields.

The two things are:

1. Ensure the scrollview is not hidden by the keyboard when its' up. Context for how to achieve this is SignupViewController animateTextViewConstraint function.
2. Also the more complicated thing but does make sense with both ResetYourFacebookPasswordViewController and SetYourPasswordViewController is to allow each textfield to move to the next and then hook up the done button to the api call on the submit button. Examples of how to do this are in SignupViewController signals like emailTextFieldReturn, nameTextFieldReturn and signupButtonPressed.

Current behaviour:

Simulator.Screen.Recording.-.iPhone.8.-.2023-01-04.at.17.11.18.mp4

In-app conforming behaviour:

Simulator.Screen.Recording.-.iPhone.8.-.2023-01-04.at.17.26.10.mp4

Those last two are big asks, so if you want me to make the changes let me know.

Maybe you can write all this up in a separate "improvements" pr?

[msadoon]

textFieldAndSetPasswordButtonAreEnabled is not being tested, please add a test for it.

[msadoon]

haha nice