Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV-ize AWS role ARN #1768

Merged
merged 1 commit into from Jan 16, 2023
Merged

ENV-ize AWS role ARN #1768

merged 1 commit into from Jan 16, 2023

Conversation

amancevice
Copy link
Contributor

ENV-ize CircleCI IAM role ARN so it can be used in both ios-* repos

@amancevice amancevice self-assigned this Jan 16, 2023
Copy link
Contributor

@msadoon msadoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turn around here!

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #1768 (29ac7c9) into main (8b15610) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1768   +/-   ##
=======================================
  Coverage   85.29%   85.29%           
=======================================
  Files        1276     1276           
  Lines      116541   116541           
  Branches    30722    30722           
=======================================
+ Hits        99406    99408    +2     
+ Misses      16068    16066    -2     
  Partials     1067     1067           
Impacted Files Coverage Δ
Library/Navigation.swift 85.85% <0.00%> (+0.64%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msadoon msadoon merged commit 25fc263 into main Jan 16, 2023
@msadoon msadoon deleted the circleci-role-arn branch January 16, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants