[PAY-2142] Fix Deeplinks Not Routing From Braze

[msadoon]

📲 What

Marketing reporting that deeplinks failed to route in-app after our upgrade of Appboy-iOS-SDK to Braze iOS SDK.
We went a few versions forward there from 4.3.2 to 5.5.0, and didn't fully test in-app deeplinking from PN's sent with Braze.

🤔 Why

Marketing campaigns blocked from being effective if content cannot be directed for all supported deeplinks.

🛠 How

Turns out we never handled the Braze deeplink in our existing implemention where we decode the payload from Braze. AppDelegateViewModel line 329 PushEnvelope has a aps case that contains an alert property which matches what's coming from Braze's payload, but the actual URL in braze's payload was a separate key called ab_uri. This key is not decoded.

So...I'm not sure how this ever worked, unless it was by accident.

Now there is a BrazePushEnvelope that handles all ab_uri's coming from the system userNotificationCenter(didRecieve, withCompletionhandler) delegate method.

there are some .pbxproj settings related to code-signing that are okay to have in because they specify the provisioning which is required by our CI to match the build type (alpha/beta/debug) with the profiles found on ios-certificates

Note:
In-app notifications are still not working as expected. The issue is that ABKInAppMessageControllerDelegate is not being triggered, but the in-app notification is coming in as a PN through UNUserNotificationCenterDelegate. Suggestion for finding the fix here is to remove Segment-Appboy-SDK, integrate with Appboy_SDK not Braze_iOS_SDK then replace Appboy_SDK with Segment-Appboy-SDK.

Made a separate ticket (NTV-647) for this.

1. Start here. Once it's complete, test pn's work and integrate for In-app notifications.
2. Troubleshooting
3. Sample with vanilla In-app notifications (no push notifications)

👀 See

Before 🐛

RPReplay_Final1674488350.MP4

After 🦋

RPReplay_Final1674488257.MP4

✅ Acceptance criteria

• Ensure deeplinks route to their destination in app. Test a few from this list. That's also the list that shows how to set up the project to accept deeplinks.

⏰ TODO

• Ensure first install deeplinks appear on device, right now they fail to appear from Braze.
• Ensure base.xcconfig and .xcodeproj related changes are not persisted unless they are file adds.
• Ensure in-app messages still come through.

[codecov]

Codecov Report

Merging #1775 (7d37965) into main (6d59c58) will decrease coverage by 0.01%.
The diff coverage is 65.21%.

@@            Coverage Diff             @@
##             main    #1775      +/-   ##
==========================================
- Coverage   85.24%   85.23%   -0.01%     
==========================================
  Files        1276     1277       +1     
  Lines      116682   116695      +13     
  Branches    30779    30786       +7     
==========================================
+ Hits        99462    99470       +8     
- Misses      16146    16150       +4     
- Partials     1074     1075       +1     

Impacted Files	Coverage Δ
KsApi/models/BrazePushEnvelope.swift	0.00% <0.00%> (ø)
Library/Tracking/Segment.swift	0.00% <0.00%> (ø)
Kickstarter-iOS/AppDelegateViewModel.swift	91.57% <90.00%> (-0.03%)	⬇️
Kickstarter-iOS/AppDelegateViewModelTests.swift	98.96% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[msadoon]

SwiftFormat found issues:

File Rules
KsApi/lib/KsApiNotification.swift:5:1 warning: (wrap) Wrap lines that exceed the specified maximum width.

Generated by 🚫 Danger

Weird formatting issue, not sure why it's putting it on a newline.

[scottkicks]

@msadoon Code looks good to me and the app runs normally. Wasn't able to test the deep-linking though because Braze isn't identifying my account.

[msadoon]

@msadoon Code looks good to me and the app runs normally. Wasn't able to test the deep-linking though because Braze isn't identifying my account.

Noted, I can't seem to register a staging only Braze user. If you're okay with approving I can run through some deeplink tests omo, or pair to show you that deeplinks work.

[scottkicks]

@msadoon that'd be great. thanks. just throw some time on my calendar whenever.