[WEB-935] Creator Dashboard Analytics #1780
Conversation
scottkicks
force-pushed
the
web-935-creator-dash-analytics
branch
from
ce74497
to
c1a4c5d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1780 +/- ##
==========================================
+ Coverage 85.22% 85.24% +0.01%
==========================================
Files 1277 1277
Lines 116544 116664 +120
Branches 30748 30795 +47
==========================================
+ Hits 99324 99445 +121
+ Misses 16147 16146 -1
Partials 1073 1073
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
good to review. checks are just running after updating this branch with main |
|
|
||
| XCTAssertEqual(["Page Viewed", "CTA Clicked"], self.segmentTrackingClient.events) | ||
|
|
||
| self.vm.inputs.switch(toProject: .id(project2.id)) |
There was a problem hiding this comment.
So you're probably not gonna switch from the same project to itself. So I guess if you start with project 1 you could switch project 2. Also along with the change to track the project being switched to, you can include a check to say the right project is being tracked when switching back and forth.
There was a problem hiding this comment.
So instead of using [.template |>] to check the assert values, you can pass in project1 and project2 directly. Makes the code less cumbersome, and easier to follow. Should pass tests, if it doesn't we'll revisit.
* syntax improvements * switch project tests improvements * make sure to get most recent value for 'self.project' via takePairWhen
scottkicks
force-pushed
the
web-935-creator-dash-analytics
branch
from
37c363f
to
2ff86bb
Compare
There was a problem hiding this comment.
Tested all the calls and they are working as expected.
Made slight modifications to the track switch signals. Encourage you to kind of study it for more exposure to reactive swift and how the value gets transformed (going from param to project, in this case). Sometimes we may have to make network calls to get data if for example we have a param only being passed through. Ask any and all questions you have, I'm happy to assist :)
Good work!
📲 What
Adding the following segment events in the creator dashboard screen.
🤔 Why
The creator dashboard doesn't have any analytic events. We want to start collecting data around whether members are finding it valuable enough to keep. The current assumption is that they don't and that we can possibly remove this feature in an effort to focus more on the backing experience.
🛠 How
I've added 3 new SegmentEvents in
KSRAnalytics, as well as tests inKSRAnalyticsTestsandDashboardViewModelTeststrackCreatorDasboardPageViewedtrackCreatorDasboardSwitchProjectClickedtrackCreatorDasboardPostUpdateClicked👀 See
No UI updates
🧪 TESTING