[Regression Fix] Braze Segment Integration Crash #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Kit and BrazeUI are not yet added. Test for crash first.
dependency `braze-ios-sdk` was crashing beyond version 4.5.1. So pinned version 4.5.1, and using `appboy-segment-ios` latest `4.6.0`
Codecov Report
@@ Coverage Diff @@
## release-5.6.1 #1785 +/- ##
=================================================
- Coverage 89.06% 85.23% -3.83%
=================================================
Files 882 1277 +395
Lines 80651 116666 +36015
Branches 21169 30794 +9625
=================================================
+ Hits 71833 99445 +27612
- Misses 8060 16148 +8088
- Partials 758 1073 +315
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
msadoon
added a commit
that referenced
this pull request
Feb 2, 2023
* updated marketing version to 5.6.1 from 5.6.0 * need to set the provisioning profiles in pbxproj files to allow fastlane to match them with ios-certificates. * updated pp from development to appstore in pbxproj * commented out fb password reset screen because the functionality didn't make sense at time of writing. * formatting * [Regression Fix] Braze Segment Integration Crash (#1785) * quick fix, missed saving launchOptions to Appboy shared instance.
msadoon
added a commit
that referenced
this pull request
Feb 2, 2023
* updated marketing version to 5.6.1 from 5.6.0 * need to set the provisioning profiles in pbxproj files to allow fastlane to match them with ios-certificates. * updated pp from development to appstore in pbxproj * commented out fb password reset screen because the functionality didn't make sense at time of writing. * formatting * [Regression Fix] Braze Segment Integration Crash (#1785) * quick fix, missed saving launchOptions to Appboy shared instance. * added provisioning profiles to pbx file to trigger build. * updated the main target to contain the manual provisioning profiles
msadoon
added a commit
that referenced
this pull request
Feb 2, 2023
* updated marketing version to 5.6.1 from 5.6.0 * need to set the provisioning profiles in pbxproj files to allow fastlane to match them with ios-certificates. * updated pp from development to appstore in pbxproj * commented out fb password reset screen because the functionality didn't make sense at time of writing. * formatting * [Regression Fix] Braze Segment Integration Crash (#1785) * quick fix, missed saving launchOptions to Appboy shared instance. * added provisioning profiles to pbx file to trigger build. * updated the main target to contain the manual provisioning profiles * added individual certs based on 5.6.0 release branch to individual targets, this may be the actual solution to the failing ci builds.
msadoon
added a commit
that referenced
this pull request
Feb 2, 2023
* updated marketing version to 5.6.1 from 5.6.0 * need to set the provisioning profiles in pbxproj files to allow fastlane to match them with ios-certificates. * updated pp from development to appstore in pbxproj * commented out fb password reset screen because the functionality didn't make sense at time of writing. * formatting * [Regression Fix] Braze Segment Integration Crash (#1785) * quick fix, missed saving launchOptions to Appboy shared instance. * added provisioning profiles to pbx file to trigger build. * updated the main target to contain the manual provisioning profiles * added individual certs based on 5.6.0 release branch to individual targets, this may be the actual solution to the failing ci builds. * after merging main something got reset in the pbx file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, the issue here is one of our dependencies
appboy-segment-ios.The discussion is currently open as an issue on their repository.
This PR addresses the temporary crash, but it sounds like it might occur in the future.
With no immediate timeline for a fix, there is a workaround that's basically the same as what we have in production now.
Workaround:
Previously we relied on
appboy-segment-ios4.6.0on SPM to download it's own dependency forbraze-ios-sdkAKAAppboyKit_iOS-SDK. Which at time of this writing is4.5.3.However as noted in the issue, we are experiencing a crash with
4.5.3, so this temporary fix is to pin4.5.1, because it's currently used in production. This should get us through regression testing and be production safe because our production version of this SDK is4.5.1and has been for many months.As soon as this issue is in a release from Braze, we can retest the scenario (checkout with Apple Pay on the production Kickstarter app) and remove pinned
braze-ios-sdk, instead relying on the dependency fromappboy-segment-ios.