[WEB-970] Part 1: Add New Property sendMetaCapiEvents #1795

scottkicks · 2023-02-21T18:35:42Z

📲 What

Add new property to help determine if we need to send CAPI events to the backend

sendMetaCapiEvents

🤔 Why

This new property will help tell us if we should send CAPI events

🛠 How

Added this property to the Project fragment.

...
sendMetaCapiEvents
...

✅ Acceptance criteria

Project page and Dashboard loads and no missing data. User can pledge/back/edit pledge/view comments/view updates, etc. No new functionality added.

scottkicks · 2023-02-22T17:47:46Z

@msadoon For some reason I'm getting this error locally in the auto generated GraphAPI file on build. Its keeping me from testing the currently failing file. I'm wondering if you see the same on your end.
I went through the usual clear cache, derived data, reset packages, etc.. but I think something isn't actually clearing on my end 🤔

msadoon · 2023-02-22T19:24:44Z

Weird, I pulled down your branch and it just built right away. Not sure...

sclampet · 2023-02-22T19:27:36Z

Weird, I pulled down your branch and it just built right away. Not sure...

Did KsApi test run?

msadoon · 2023-02-22T20:27:55Z

Weird, I pulled down your branch and it just built right away. Not sure...

Did KsApi test run?

Yea so it took me bit to find the error, related to some test templates we were using, the last commit should have the fix. :)

codecov · 2023-02-22T21:27:56Z

Codecov Report

Merging #1795 (578b5b3) into main (dc3831b) will decrease coverage by 0.03%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
- Coverage   85.47%   85.45%   -0.03%     
==========================================
  Files        1282     1282              
  Lines      117246   117291      +45     
  Branches    31037    31042       +5     
==========================================
+ Hits       100213   100226      +13     
- Misses      15958    15990      +32     
  Partials     1075     1075

Impacted Files	Coverage Δ
KsApi/models/lenses/ProjectLenses.swift	`16.83% <13.55%> (-0.59%)`	⬇️
KsApi/models/Project.swift	`80.32% <100.00%> (+0.16%)`	⬆️
...raphql/adapters/Backing+BackingFragmentTests.swift	`98.58% <100.00%> (+<0.01%)`	⬆️
.../adapters/Project+FetchProjectQueryDataTests.swift	`96.40% <100.00%> (+0.02%)`	⬆️
...els/graphql/adapters/Project+ProjectFragment.swift	`91.03% <100.00%> (+0.04%)`	⬆️
...raphql/adapters/Project+ProjectFragmentTests.swift	`97.82% <100.00%> (+0.01%)`	⬆️
...ons/templates/query/FetchAddOnsQueryTemplate.swift	`98.93% <100.00%> (+<0.01%)`	⬆️
...ns/templates/query/FetchProjectQueryTemplate.swift	`98.31% <100.00%> (+<0.01%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

msadoon

Great work!

msadoon · 2023-02-23T15:19:01Z

Kickstarter.xcodeproj/project.pbxproj

+		606F215A299D3EF800BA5CDF /* GraphAPI.TriggerCapiEventInput+TriggerCapiEventInputTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "GraphAPI.TriggerCapiEventInput+TriggerCapiEventInputTests.swift"; sourceTree = "<group>"; };
+		606F215D299D414800BA5CDF /* GraphAPI.TriggerCapiEventInput+TriggerCapiEventInput.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "GraphAPI.TriggerCapiEventInput+TriggerCapiEventInput.swift"; sourceTree = "<group>"; };
+		606F2165299D456D00BA5CDF /* TriggerCapiEvent.graphql */ = {isa = PBXFileReference; lastKnownFileType = text; path = TriggerCapiEvent.graphql; sourceTree = "<group>"; };
+		606F2167299D45F900BA5CDF /* TriggerCapiEventInput.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TriggerCapiEventInput.swift; sourceTree = "<group>"; };


Weird that TriggerCapiEventInputInput showing multiple times...I checked the finder folder and xcode and the file is there only once.

ok i will keep this in mind as I work through Part 2 and see if git is caching it for some reason.

scottkicks added 5 commits February 21, 2023 13:37

set up TriggerCapiEventInput mutation

b0c2bdc

set up TriggerCapiEventInput mutation

bab576e

update graphql-schema

f4f6671

decode new sendMetaCapiEvents property from project

7ac83d2

rebase main and format

4481694

scottkicks force-pushed the web-970 branch from de8956f to 4481694 Compare February 21, 2023 18:38

scottkicks self-assigned this Feb 21, 2023

scottkicks added the enhancement label Feb 21, 2023

scottkicks added this to the release-5.7.0 milestone Feb 21, 2023

scottkicks changed the title ~~[WEB-970] Add New Property sendMetaCapiEvents~~ [WEB-970] Part 1: Add New Property sendMetaCapiEvents Feb 21, 2023

scottkicks force-pushed the web-970 branch 2 times, most recently from e7bf6a7 to ffc273f Compare February 22, 2023 16:38

update tests

f28c4dc

scottkicks force-pushed the web-970 branch from ffc273f to f28c4dc Compare February 22, 2023 17:23

kickstarter deleted a comment from nativeksr Feb 22, 2023

format

fb54de5

this shouldn't fail the ksAPI tests

17bb356

Merge branch 'main' into web-970

578b5b3

scottkicks marked this pull request as ready for review February 22, 2023 22:11

scottkicks requested a review from msadoon February 22, 2023 22:11

msadoon approved these changes Feb 23, 2023

View reviewed changes

scottkicks merged commit 06262b2 into main Feb 24, 2023

scottkicks deleted the web-970 branch February 24, 2023 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WEB-970] Part 1: Add New Property sendMetaCapiEvents #1795

[WEB-970] Part 1: Add New Property sendMetaCapiEvents #1795

scottkicks commented Feb 21, 2023 •

edited

scottkicks commented Feb 22, 2023 •

edited

msadoon commented Feb 22, 2023

sclampet commented Feb 22, 2023

msadoon commented Feb 22, 2023

codecov bot commented Feb 22, 2023 •

edited

msadoon left a comment

msadoon Feb 23, 2023 •

edited

scottkicks Feb 24, 2023

[WEB-970] Part 1: Add New Property sendMetaCapiEvents #1795

[WEB-970] Part 1: Add New Property sendMetaCapiEvents #1795

Conversation

scottkicks commented Feb 21, 2023 • edited

📲 What

🤔 Why

🛠 How

✅ Acceptance criteria

scottkicks commented Feb 22, 2023 • edited

msadoon commented Feb 22, 2023

sclampet commented Feb 22, 2023

msadoon commented Feb 22, 2023

codecov bot commented Feb 22, 2023 • edited

Codecov Report

msadoon left a comment

Choose a reason for hiding this comment

msadoon Feb 23, 2023 • edited

Choose a reason for hiding this comment

scottkicks Feb 24, 2023

Choose a reason for hiding this comment

scottkicks commented Feb 21, 2023 •

edited

scottkicks commented Feb 22, 2023 •

edited

codecov bot commented Feb 22, 2023 •

edited

msadoon Feb 23, 2023 •

edited