Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-999] Prelaunch Dates Blockers #1801

Merged
merged 3 commits into from Mar 9, 2023

Conversation

msadoon
Copy link
Contributor

@msadoon msadoon commented Mar 8, 2023

📲 What

As outlined in this ticket we needed to update our existing project model deadline and launchedAt properties to optional instead of non-optional.

Reason is because the prelaunch pages do not have those fields populated in GQL and the existing project page works off of GQL not v1.

Obviously this isn't the final version of the prelaunch, but necessary to get the latest data for the eventual page UI.

🤔 Why

As stated above, we need the deadline and launchedAt dates to be optional for those fields to be populated in order for the guard check to pass in Project+ProjectFragment dates

🛠 How

Did a project search for both properties and found instances of their use. In cases where optionals where being returned already, just needed to add the property to the if let or guard let. Otherwise returned a sensible value (ie. for String was "", or Int was 1).

There are lot of places where these fields occur and going through them all with breakpoints helped validate that nothing was broken or out of place.

Mostly though relied on optional checks to safely unwrap properties that were once non-optional.

Also fixed up tests to pass, not too much to do there.

👀 See

Before 🐛 After 🦋
non-optional_v1 optional_gql

✅ Acceptance criteria

  • Run through the app with breakpoints for whereever deadline or launchedAt or computed properties of those two were being used, hit breakpoint, ensure optional check passes.

@msadoon msadoon requested a review from scottkicks March 8, 2023 21:52
@msadoon msadoon self-assigned this Mar 8, 2023
@msadoon msadoon added this to the release-5.7.0 milestone Mar 8, 2023
Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran through breakpoints and all optional checks are passing

@msadoon msadoon merged commit 2fb519b into main Mar 9, 2023
@msadoon msadoon deleted the web-999/prelaunch-date-launchat-convert-optionality branch March 9, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants