Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-671] Corrected Search State of Prelaunch Cells #1804

Merged
merged 3 commits into from Mar 27, 2023

Conversation

msadoon
Copy link
Contributor

@msadoon msadoon commented Mar 23, 2023

📲 What

When searching for prelaunch projects (and also in saved projects under backer profile) we need to update their existing state to not look so broken.

🤔 Why

It just makes it clear to the backer/user what state the project is in before they click it.

🛠 How

Designs

This was pretty simple, we check one of three flags to be true before emitting a prelaunch Bool to update the UI for the cell.

If the project launcehdAt <=0, displayPrelaunch is true or prelaunchActivated is true, then we update the UI of the cell to its' prelaunch state.

Only two cells affects BackerDashboardProjectCell and MostPopularSearchProjectCell

I found those two cells to be used in SearchViewController and BackerDashboardViewController.

👀 See

Trello, screenshots, external resources?

Before 🐛

After 🦋

✅ Acceptance criteria

  • Ensure designs look almost identical (I know there are small differences in padding and search text, but I feel that's an okay tradeoff)

⏰ TODO

  • Write tests

@msadoon msadoon added this to the release-5.7.0 milestone Mar 23, 2023
@msadoon msadoon self-assigned this Mar 23, 2023
@msadoon msadoon requested a review from scottkicks March 23, 2023 19:26
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #1804 (7be696e) into main (284ef75) will increase coverage by 0.00%.
The diff coverage is 97.50%.

❗ Current head 7be696e differs from pull request most recent head c945491. Consider uploading reports for the commit c945491 to get more accurate results

@@           Coverage Diff           @@
##             main    #1804   +/-   ##
=======================================
  Coverage   85.35%   85.36%           
=======================================
  Files        1286     1286           
  Lines      117942   118021   +79     
  Branches    31232    31261   +29     
=======================================
+ Hits       100675   100752   +77     
- Misses      16181    16183    +2     
  Partials     1086     1086           
Impacted Files Coverage Δ
...Models/MostPopularSearchProjectCellViewModel.swift 93.50% <91.66%> (-0.34%) ⬇️
...ewModels/BackerDashboardProjectCellViewModel.swift 93.25% <93.75%> (+0.01%) ⬆️
...jects/Views/Cells/BackerDashboardProjectCell.swift 98.38% <100.00%> (+0.08%) ⬆️
.../Search/Controller/SearchViewControllerTests.swift 100.00% <100.00%> (ø)
...arch/Views/Cell/MostPopularSearchProjectCell.swift 98.55% <100.00%> (+0.06%) ⬆️
...els/BackerDashboardProjectCellViewModelTests.swift 98.91% <100.00%> (+0.14%) ⬆️
...s/MostPopularSearchProjectCellViewModelTests.swift 98.64% <100.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msadoon
Copy link
Contributor Author

msadoon commented Mar 27, 2023

@scottkicks again, hope you don't mind I merge this without your review for this release cycle. Please come back and review this after if you want. We'll also being doing a QA party on this feature so it should be okay.

@msadoon msadoon merged commit d1cd72e into main Mar 27, 2023
@msadoon msadoon deleted the mb-671/prelaunch-search-state-ui branch March 27, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant