[MBL-658] Replace Real Optimizely Client With Mock

[msadoon]

📲 What

To address our deadline of shipping the removal of Optimizely by April 17, here is a tiddy solution that should hold us over until we implement our next feature flagging tool. Probably Firebase Remote Config.

This document goes into more detail about the hows and whys.

🤔 Why

Removing Optimizely saves us an expensive subscription that can be replaced for free by more useful tools like Firebase Remote Config.

🛠 How

MockOptimizelyClient is actually a 1-1 replacement of the core functionality of the real Optimizely client.

In fact we pass around a OptimizelyClientType which is a protocol that is mapped to the functions used in Optimizely. we pass it around via our AppEnvironment.current.optimizelyClient singleton variable. MockOptimizelyClient conforms to this protocol.

So in the sake of saving the time to remove each individual flag throughout our app, why not hardcode those values as they are now on Optimizely dashboard?

We don't need to worry about older versions either, because as that document goes into more detail, even if the configuration of the real Optimizely SDK fails, we handle all experiments as a control case and all features as a false case. So at worst features that were enabled for versions 5.4.0 (project story tab), 5.5.0 (stripe payment settings) and 5.6.0 (stripe payment sheet) stop working until users update to this version 5.7.0. No crashes should occur because we handle the errors in our use cases.

Updating those users is probably going to be a campaign with in-app notifications down the line.

The thing to note is this MockOptimizelyClient is good enough that it covers of the entire scope of work for this ticket. So none of the subtickets need to be done until we actually have Remote Config setup to create that feature/experiment.

Aside: To get a sense of our active daily users for each version, check our app analytics in the document above.

✅ Acceptance criteria

• Ensure existing features and experiments behave exactly as they do in the production app version.

⏰ Developer QA

Step 1. Record the optimizely variable values after launching this pr in a build. Hint: use breakpoints

Experiments
DiscoveryViewModel activateNativeProjectCardsExperiment —> .control
OptimizelyExperiment nativeProjectCardsExperimentVariant —> .control
AppDelegateViewModel shouldSeeCategoryPersonalization —> .control
AppDelegateViewModel shouldGoToLandingPage —> .control
DiscoveryPageViewModel shouldShowPersonalization —> .control

Features

AppDelegateViewModel featureConsentManagementDialogEnabled —> false
ProjectPamphletMainCellViewModel featureProjectPageStoryTabEnabled —> true
ProjectNavigationSelectorViewModel featureProjectPageStoryTabEnabled —> true
CommentCellViewModel featureCommentFlaggingIsEnabled —> false
PledgePaymentMethodsViewModel featurePaymentSheetEnabled —> true
PaymentMethodsFooterView featureSettingsPaymentSheetEnabled —> true
AppDelegateViewModel featureConsentManagementDialog —> false

OptimizelyFeatureFlagToolsViewModel
comment flagging isEnabled fromServer == false, isEnabledFromUserDefaults nil
consent management isEnabledfromServer == false, isEnabledFromUserDefaults nil
conversions_api isEnabledFromServer == false, isEnabledFromUserDefaults nil
facebook deprecation isEnabledFromServer == false, isEnabledfromuserDefaults nil
payment sheet isEnabledFromServer == true, isEnabledFromUserDefaults nil
project story tab isEnabledFromServer == true, isEnabledFromUserDetauls nil
settings payment sheet isEnabledFromServer == true, isEnabledFromUserDefaults nil

Untested experiments: native_onboarding_series_new_backers
Untested features: ios_facebook_deprecation, ios_facebook_conversions_api

Step 2. Ensure UserDefaults is being activated through Beta tools
[Experiments are not stored in UserDefaults]

Instructions: a) turn on/off feature through Optimizely Feature Flags. b) kill app, don’t delete, relaunch through XCode c) ensure feature is being displayed as expected.

To record values, you might need to set breakpoints. Should be opposite values of what's recorded above.

CommentCellViewModel featureCommentFlaggingIsEnabled —> true
AppDelegateViewModel featureConsentManagementDialogEnabled —> true
PledgePaymentMethodsViewModel featurePaymentSheetEnabled —> false
ProjectPamphletMainCellViewModel featureProjectPageStoryTabEnabled —> false
ProjectNavigationSelectorViewModel featureProjectPageStoryTabEnabled —> false
PaymentMethodsFooterView featureSettingsPaymentSheetEnabled —> true

Untested experiments: native_onboarding_series_new_backers —> requires new users.
Untested features: ios_facebook_deprecation, ios_facebook_conversions_api —> requires facebook login, unused

Step 3. Repeat for Step 1 for version of app with Optimizely and check that variables are being set the same way as this pr build

Caveat:
Things are still named around Optimizely so we should update that once we have our new feature flagging tool set up.

#❓Questions/Future Work

• Conversions api ff not used, can we remove?
• Update native-secrets to remove optimizely secret keys
• Fix weird bug found on old payment sheet in settings: cannot open payment sheet after cancelling unless re-enter page.

[scottkicks]

Yes we can remove this one since the CAPI code is gated behind the user's consent preferences instead of this flag

[scottkicks]

Looks like we just need to update some optimizely tests to reflect the removal of the conversions flag. Good to go after that.

Ran through the Developer QA steps and everything was working as expected 🎉

[msadoon]

Looks like we just need to update some optimizely tests to reflect the removal of the conversions flag. Good to go after that.

Ran through the Developer QA steps and everything was working as expected 🎉

Thanks for quick and thorough review on this! I just have to fix the tests and we'll merge