Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-696] Cleanup Optimizely Experiments #1812

Merged
merged 32 commits into from
Apr 19, 2023
Merged

[MBL-696] Cleanup Optimizely Experiments #1812

merged 32 commits into from
Apr 19, 2023

Commits on Apr 11, 2023

  1. remove nativeOnboarding experiment

    @scottkicks
    scottkicks committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    738a49f View commit details
    Browse the repository at this point in the history

  2. remove onboardingCategoryPersonalizationFlow experiment

    @scottkicks
    scottkicks committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    f8f943b View commit details
    Browse the repository at this point in the history

  3. remove nativeProjectCards experiment

    @scottkicks
    scottkicks committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0adadf4 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. remove nativeRiskMessaging experiment. leave affected code for now un… 

    …til more I can get more feature context
    @scottkicks
    scottkicks committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    a85ebe3 View commit details
    Browse the repository at this point in the history

  2. remove OptimizelyExperiment file

    @scottkicks
    scottkicks committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    b979933 View commit details
    Browse the repository at this point in the history

  3. remove goToLandingPage flow and LandingPage files

    @scottkicks
    scottkicks committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    9cf5163 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. remove hasSeenLandingPage from KeyValueStoreType

    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    aa6fbba View commit details
    Browse the repository at this point in the history

  2. remove hasSeenCategoryPersonalizationFlow from KeyValueStoreType

    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    fe2743a View commit details
    Browse the repository at this point in the history

  3. remove shouldSeeCategoryPersonalization(), goToCategoryPersonalizatio… 

    …nOnboarding output, and LandingViewController/LandingViewModel and tests
    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    d2ef0b1 View commit details
    Browse the repository at this point in the history

  4. rename testDeeplink and testOpenPushNotification_WhenOnboardingFlowIs… 

    …NotActive tests
    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    1950b3b View commit details
    Browse the repository at this point in the history

  5. add _Success suffix to testContinueUserActivity

    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    31ef1f0 View commit details
    Browse the repository at this point in the history

  6. add _Success suffix to testPerformShortcutItem_

    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    91ebb47 View commit details
    Browse the repository at this point in the history

  7. remove experiment name from testLaunchShortcutItem_WhenOnboardingFlow… 

    …IsNotActive test
    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b2fb981 View commit details
    Browse the repository at this point in the history

  8. remove testEmailDeepLinking_WhenOnboardingFlowIsNotActive

    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    e1de13f View commit details
    Browse the repository at this point in the history

  9. clean up projectsLoaded output in DiscoveryPageViewModel

    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    47f82e3 View commit details
    Browse the repository at this point in the history

  10. .zero format suggestion

    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    68bfcd3 View commit details
    Browse the repository at this point in the history

  11. put testConfigureDataSourceOptimizelyConfiguration test back

    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    771b6b5 View commit details
    Browse the repository at this point in the history

  12. put testProjectsLoaded_Success back

    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    415bb23 View commit details
    Browse the repository at this point in the history

  13. put testContentInset_Success back

    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ecd1a95 View commit details
    Browse the repository at this point in the history

  14. put testShowPersonalization_LoggedOut and testShowPersonalization_Log… 

    …gedIn back
    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    a23f0e1 View commit details
    Browse the repository at this point in the history

  15. put testShowPersonalization_When_HasCompletedCategorySelection_IsFals… 

    …e back
    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    82304a0 View commit details
    Browse the repository at this point in the history

  16. put testShowPersonalization_When_HasDismissedPersonalizationCell_IsTr… 

    …ue back
    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    f2517e8 View commit details
    Browse the repository at this point in the history

  17. remove experiments property and related methods from MockOptimizelyCl… 

    …ient
    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    17e1e4e View commit details
    Browse the repository at this point in the history

  18. remove _Control suffix from testDiscoveryPageBackgroundColor

    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b34e2d0 View commit details
    Browse the repository at this point in the history

  19. clean up experiments related code from MockOptimizelyClient

    @scottkicks
    scottkicks committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    2535c6b View commit details
    Browse the repository at this point in the history

  20. Merge branch 'main' into scott/clean-up-experiments

    @msadoon
    msadoon committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    a4ced6f View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. remove LandingViewModel and LandingViewModelTests

    @scottkicks
    scottkicks committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    2c48644 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'scott/clean-up-experiments' of https://github.com/kicks… 

    …tarter/ios-oss into scott/clean-up-experiments
    @scottkicks
    scottkicks committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    71eab2f View commit details
    Browse the repository at this point in the history

  3. remove unecessary test

    @scottkicks
    scottkicks committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    696d888 View commit details
    Browse the repository at this point in the history

  4. update testDiscoveryPageBackgroundColor test name to testIsNativeRisk… 

    …MessagingControlEnabled
    @scottkicks
    scottkicks committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    3f927b2 View commit details
    Browse the repository at this point in the history

  5. undo naming since there is already a test with that name and use case

    @scottkicks
    scottkicks committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    fd5bfda View commit details
    Browse the repository at this point in the history

  6. remov LandingPageViewControllerTests and LandingViewControllerTests s… 

    …napshots
    @scottkicks
    scottkicks committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    2ca694e View commit details
    Browse the repository at this point in the history