Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-703] Prelaunch Page Watch Count Update #1813

Merged
merged 3 commits into from Apr 17, 2023

Conversation

msadoon
Copy link
Contributor

@msadoon msadoon commented Apr 12, 2023

πŸ“² What

We noticed that prelaunch page watch count was not being accurately update after saving/unsaving the project.

πŸ€” Why

Matching Android functionality. Also makes more sense to show the new follower count after following a project.

πŸ›  How

Modified the .graphql files for Unwatch and Watch project to include watchesCount.
Updated the envelope to have this property after getting it back from the mutation data.
The PledgeStateCTAType has a new property within the prelaunch enum case for watchesCount.

We merge the new pledge state with watchesCount to the watchesCountText in PledgeCTAContainerViewViewModel which was previously just using the project it was configured with for that text.

All the other signals/notifications should be the same, it's just about keeping track of the watchesCount after the network response returns for unwatchProject and watchProject.

πŸ‘€ See

Before πŸ›

RPReplay_Final1681320063.MP4

After πŸ¦‹

RPReplay_Final1681319958.MP4

βœ… Acceptance criteria

  • Ensure watching and unwatching a prelaunch project is accurate to the web.

@msadoon msadoon added the WIP label Apr 12, 2023
@msadoon msadoon added this to the release 5.8.0 milestone Apr 12, 2023
@msadoon msadoon self-assigned this Apr 12, 2023
@msadoon msadoon marked this pull request as ready for review April 12, 2023 18:32
@msadoon msadoon requested a review from scottkicks April 12, 2023 18:32
@msadoon msadoon added needs review and removed WIP labels Apr 12, 2023
Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! looks great and works as expected πŸ‘

@msadoon msadoon merged commit e48374f into main Apr 17, 2023
5 checks passed
@msadoon msadoon deleted the mbl-703/save-unsave-prelaunch-projects-followers-count branch April 17, 2023 18:11
@msadoon msadoon modified the milestones: release 5.8.0, release-5.8.0 Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants