[MBL-721] Remote Config Local Feature Flags #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…environment instance
Generated by 🚫 Danger |
msadoon
suggested changes
May 9, 2023
There was a problem hiding this comment.
Ok, nice quick work here.
For some reason I'm not getting the flags to show in-app:
Simulator.Screen.Recording.-.iPhone.8.-.2023-05-09.at.15.04.29.mp4
Also address the questions below and I'll take another look, likely on Thursday. I want to focus heads down and get the xcode upgrade ready for review tomorrow.
Kickstarter-iOS/Features/BetaTools/Controller/BetaToolsViewController.swift
Outdated
Show resolved
Hide resolved
...mizelyFeatureFlagToolsViewControllerTests/testOptimizelyFeatureFlagToolsViewController.1.png
Outdated
Show resolved
Hide resolved
Library/ViewModels/RemoteConfigFeatureFlagToolsViewModelTests.swift
Outdated
Show resolved
Hide resolved
|
addressed your comments @msadoon take your time reviewing. no rush! |
msadoon
approved these changes
May 9, 2023
There was a problem hiding this comment.
Yep so good to go - I noticed that the defaults load first not the dashboard values (on fresh install). Then re-launching picks up the dashboard values. Just as a discussion this seems acceptable to me, but let me know if you think dashboard values should be shown on first install launch instead of default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Now that we have RemoteConfig configured, lets get our local feature flags in our debug menu working.
🤔 Why
Some background context on why the change is needed.
🛠 How
These toggles will first reference values stored in user defaults, if there is one, before referencing the values currently published in our firebase console.
Allowing us to test our app with different flags enbaled/disabled without impacting production.
We're using the same pattern here that we've had with Optimizely, so this is mostly renames and making sure that we're referencing the
RemoteConfigClientTypethat is now inAppEnvironment👀 See
Trello, screenshots, external resources?
✅ Acceptance criteria
Make sure you run the app using our
AppCenter Alphascheme to test.