Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-841] Release 5.8.0 to Main #1824

Merged
merged 1 commit into from May 30, 2023
Merged

[MBL-841] Release 5.8.0 to Main #1824

merged 1 commit into from May 30, 2023

Conversation

scottkicks
Copy link
Contributor

This is the release from 5.8.0 to Main

@scottkicks scottkicks added this to the release-5.8.0 milestone May 30, 2023
@scottkicks scottkicks requested a review from msadoon May 30, 2023 13:33
@scottkicks scottkicks self-assigned this May 30, 2023
@scottkicks
Copy link
Contributor Author

Since Mubarak is on vacation, this is a non reviewed merge.

@scottkicks scottkicks changed the title Release 5.8.0 to Main [MBL-841] Release 5.8.0 to Main May 30, 2023
@scottkicks scottkicks marked this pull request as ready for review May 30, 2023 14:19
@scottkicks scottkicks merged commit cf6fac4 into main May 30, 2023
4 checks passed
@scottkicks scottkicks deleted the release-5.8.0 branch May 30, 2023 14:19
@scottkicks scottkicks restored the release-5.8.0 branch May 30, 2023 14:19
msadoon
msadoon reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@msadoon msadoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, mostly done correctly.
So next up. I want you to write a separate PR - for removing unneeded additions of MARKETING_VERSION = 5.7.0. Only keep the changes that update the number NOT add the marketing version where it previously was not there.

Kickstarter.xcodeproj/project.pbxproj
@@ -9239,6 +9239,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 5.8.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not introduce uneccessary changes here. If it previously was not there, no need to add it. Only need modifications with this. Ie. 5.7.0 -> 5.8.0

@scottkicks scottkicks deleted the release-5.8.0 branch June 12, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msadoon msadoon msadoon left review comments

Assignees

@scottkicks scottkicks

Labels
None yet
Projects
None yet
Milestone
release-5.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scottkicks @msadoon