Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-841] Release 5.8.0 to Main #1826

Merged
merged 1 commit into from Jun 12, 2023
Merged

[MBL-841] Release 5.8.0 to Main #1826

merged 1 commit into from Jun 12, 2023

Conversation

scottkicks
Copy link
Contributor

This is the release from 5.8.0 to Main with the correct marketing version update.

@scottkicks scottkicks self-assigned this Jun 12, 2023
@scottkicks scottkicks added this to the release-5.8.0 milestone Jun 12, 2023
@scottkicks scottkicks requested a review from msadoon June 12, 2023 14:32
@scottkicks
Copy link
Contributor Author

@msadoon please verify that the main project and all of its targets have a correct marketing version of 5.8.0

Copy link
Contributor

@msadoon msadoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but remember as agreed only assign a PR once all tests pass and not in a draft state!

@scottkicks scottkicks marked this pull request as ready for review June 12, 2023 14:53
@scottkicks
Copy link
Contributor Author

@msadoon yes just wanted to get this reviewed since most tests cases won't be impacted by these changes

@msadoon
Copy link
Contributor

msadoon commented Jun 12, 2023

@msadoon yes just wanted to get this reviewed since most tests cases won't be impacted by these changes

Yep, I just want us to follow the agreed way so we don't get miss steps in the future. Always feel free to tag me in a PR and ask questions without assigning. That way when multiple members are on the team you can always expect a PR to be assigned once it's ready to be merged. In my experience it causes less confusion especially with large PRs, (ie. commits being added while review is happening, random test failures, etc.)

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #1826 (3e3a0f2) into main (cf6fac4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1826   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files        1276     1276           
  Lines      115449   115449           
  Branches    30743    30743           
=======================================
  Hits        97392    97392           
  Misses      16990    16990           
  Partials     1067     1067           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@scottkicks scottkicks merged commit 0e92dd6 into main Jun 12, 2023
6 checks passed
@scottkicks scottkicks deleted the release-5.8.0 branch June 12, 2023 15:39
@scottkicks scottkicks restored the release-5.8.0 branch June 12, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants