Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-873] Setup TriggerThirdPartyEvent GraphQL Mutation #1833

Merged
merged 3 commits into from Jul 17, 2023

Conversation

scottkicks
Copy link
Contributor

@scottkicks scottkicks commented Jul 12, 2023

📲 What

We need to update our GraphSchema so that we can use the new TriggerThirdPartyEvent mutation.

🤔 Why

This mutation allows us to send both facebook ad and google analytics data relevant to the user.
The backend will now determine which third party to use for us. For more details please see the engineering plan that I wrote for this.

🛠 How

  • update graphql-schema
  • update MockService
  • update Service and ServiceType
  • create new adapter files
  • create TriggerThirdPartyInput
  • create TriggerThirdPartyEvent.graphql in /mutations

The work to address replacing existing triggerCapiEventInput calls will be done in the next PR.
That will also clean up all TriggerCapiEventInput related files.

✅ Acceptance criteria

  • GraphAPI has been updated with the new mutation and all tests pass
  • The new TriggerThirdPartyEvent mutation is ready to be referenced in the app.

@scottkicks scottkicks self-assigned this Jul 12, 2023
@scottkicks scottkicks added this to the release-5.9.0 milestone Jul 12, 2023
@scottkicks scottkicks force-pushed the scott/mbl-876-update-graphschema branch 2 times, most recently from 676ad81 to 5c7a051 Compare July 13, 2023 16:37
* update Service and ServiceType
* update MockService
* create new adapter files
* convert TriggerCapiEventInput to TriggerThirdPartyInput
* create TriggerThirdPartyEvent.graphql in /mutations
@scottkicks scottkicks force-pushed the scott/mbl-876-update-graphschema branch from 5c7a051 to ba2b7e6 Compare July 13, 2023 18:27
@kickstarter kickstarter deleted a comment from nativeksr Jul 13, 2023
@scottkicks scottkicks marked this pull request as ready for review July 13, 2023 19:22
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #1833 (ba2b7e6) into main (268fbed) will increase coverage by 0.00%.
The diff coverage is 88.11%.

@@           Coverage Diff            @@
##             main    #1833    +/-   ##
========================================
  Coverage   84.46%   84.47%            
========================================
  Files        1274     1278     +4     
  Lines      115157   115258   +101     
  Branches    30660    30688    +28     
========================================
+ Hits        97268    97359    +91     
- Misses      16821    16831    +10     
  Partials     1068     1068            
Impacted Files Coverage Δ
KsApi/Service.swift 9.25% <0.00%> (-0.15%) ⬇️
KsApi/ServiceType.swift 76.06% <ø> (ø)
KsApi/MockService.swift 13.22% <14.28%> (+<0.01%) ⬆️
...dPartyEventInput+TriggerThirdPartyEventInput.swift 100.00% <100.00%> (ø)
...yEventInput+TriggerThirdPartyEventInputTests.swift 100.00% <100.00%> (ø)
...mutations/inputs/TriggerThirdPartyEventInput.swift 100.00% <100.00%> (ø)
...ions/inputs/TriggerThirdPartyEventInputTests.swift 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@scottkicks scottkicks changed the title [MBL-873] Setup TriggerThirdPartyEvent Mutation [MBL-873] Setup TriggerThirdPartyEvent GraphQL Mutation Jul 13, 2023
@scottkicks scottkicks requested a review from msadoon July 13, 2023 19:25
@scottkicks scottkicks merged commit 4b48213 into main Jul 17, 2023
7 checks passed
@scottkicks scottkicks deleted the scott/mbl-876-update-graphschema branch July 17, 2023 16:09
@msadoon msadoon mentioned this pull request Jul 19, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants