Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-888] Update Creator Dashboard Deprecation Date #1837

Merged
merged 1 commit into from Jul 25, 2023
Merged

Conversation

scottkicks
Copy link
Contributor

@scottkicks scottkicks commented Jul 25, 2023

πŸ“² What

Updates the date shown in the creator dashboard deprecation banner.

πŸ€” Why

Users should have an accurate notice of when this feature will be removed.

πŸ›  How

The banner has already been built and the existing date is formatted correctly. So, all we need to is update the date being passed in.

πŸ‘€ See

Trello, screenshots, external resources?

Before πŸ› After πŸ¦‹

βœ… Acceptance criteria

  • Login as a creator using the 1Password credentials for therealnativesquad@gmail.com, navigate to the creator dashboard tab, the new date on the banner should read September 5, 2023

@scottkicks scottkicks self-assigned this Jul 25, 2023
@scottkicks scottkicks added this to the release-5.9.0 milestone Jul 25, 2023
@scottkicks
Copy link
Contributor Author

requesting review early because this is somewhat time sensitive and doesn't impact any tests.

@scottkicks scottkicks marked this pull request as ready for review July 25, 2023 17:37
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1837 (08724c7) into main (91d3abe) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1837   +/-   ##
=======================================
  Coverage   84.54%   84.54%           
=======================================
  Files        1273     1273           
  Lines      115190   115190           
  Branches    30656    30656           
=======================================
+ Hits        97387    97389    +2     
+ Misses      16734    16732    -2     
  Partials     1069     1069           
Files Changed Coverage Ξ”
...rdDeprecationBanner/DashboardDeprecationView.swift 0.00% <0.00%> (ΓΈ)

... and 1 file with indirect coverage changes

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@scottkicks scottkicks merged commit dbc32da into main Jul 25, 2023
6 checks passed
@scottkicks scottkicks deleted the scott/mbl-888 branch July 25, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants