Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-900] Use of AI Tab #1842

Merged
merged 7 commits into from
Aug 14, 2023
Merged

[MBL-900] Use of AI Tab #1842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bfde6bc
Updated model with ai disclosure fields
msadoon Aug 2, 2023
bb2c048
added use of ai tab
msadoon Aug 8, 2023
32dd553
Merge branch 'main' into mbl-900/new-tab-use-of-ai
msadoon Aug 9, 2023
b879f74
Merge branch 'main' into mbl-900/new-tab-use-of-ai
msadoon Aug 9, 2023
f913b88
fixed a test for use of ai tab title
msadoon Aug 9, 2023
e32af42
Merge branch 'mbl-900/new-tab-use-of-ai' of https://github.com/kickst…
msadoon Aug 9, 2023
ad87197
formatting
msadoon Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewControllerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ internal final class ProjectPageViewControllerTests: TestCase {
id: 0,
createdAt: MockDate().timeIntervalSince1970
)],
aiDisclosure: nil,
risks: "These are the risks",
story: ProjectStoryElements(htmlViewElements:
[
Expand Down Expand Up @@ -54,6 +55,7 @@ internal final class ProjectPageViewControllerTests: TestCase {
private let emptyProjectProperties = ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: ProjectStoryElements(htmlViewElements: []),
minimumPledgeAmount: 1
Expand Down Expand Up @@ -1029,6 +1031,8 @@ internal final class ProjectPageViewControllerTests: TestCase {
}
}

// FIXME: Add test for "Use of AI" tab: https://kickstarter.atlassian.net/browse/MBL-902

func testLoggedOut_NonBacker_LiveProjectSwitchedToEnvironmentalCommitmentsTab_Success() {
let config = Config.template
let project = Project.cosmicSurgery
Expand All @@ -1054,7 +1058,7 @@ internal final class ProjectPageViewControllerTests: TestCase {
scheduler.advance()

// INFO: We are not testing that the navigation selector view, just the content of the view controller after the tab selection occurs.
vc.projectNavigationSelectorViewDidSelect(ProjectNavigationSelectorView(), index: 4)
vc.projectNavigationSelectorViewDidSelect(ProjectNavigationSelectorView(), index: 5)

scheduler.run()

Expand Down
3 changes: 3 additions & 0 deletions ...-iOS/Features/ProjectPage/Datasource/Datasource/ProjectPageViewControllerDataSource.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,9 @@
cellClass: ProjectRisksDisclaimerCell.self,
inSection: Section.risksDisclaimer.rawValue
)
case .aiDisclosure:
// TODO: Doing in: https://kickstarter.atlassian.net/browse/MBL-902

Check warning on line 210 in Kickstarter-iOS/Features/ProjectPage/Datasource/Datasource/ProjectPageViewControllerDataSource.swift

View check run for this annotation

Codecov / codecov/patch

Kickstarter-iOS/Features/ProjectPage/Datasource/Datasource/ProjectPageViewControllerDataSource.swift#L210 

Added line #L210 was not covered by tests
_ = {}
case .environmentalCommitments:
let environmentalCommitments = project.extendedProjectProperties?.environmentalCommitments ?? []

Expand Down
22 changes: 22 additions & 0 deletions ...Features/ProjectPage/Datasource/Datasource/ProjectPageViewControllerDataSourceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: self.faqs,
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -147,6 +148,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: self.faqs,
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -192,6 +194,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -246,6 +249,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -287,6 +291,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "These are all the risks and challenges associated with this project. Lorem Ipsum",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -334,11 +339,14 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
}
}

// FIXME: Add test for "Use of AI" tab: https://kickstarter.atlassian.net/browse/MBL-902

func testLoadEnvironmentalCommitments() {
let project = Project.template
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: self.environmentalCommitments,
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -394,6 +402,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -445,6 +454,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -500,6 +510,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -549,6 +560,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: self.faqs,
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand All @@ -570,6 +582,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand All @@ -594,6 +607,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand All @@ -617,6 +631,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -679,6 +694,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -743,6 +759,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -795,6 +812,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -848,6 +866,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -894,6 +913,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -941,6 +961,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down Expand Up @@ -993,6 +1014,7 @@ final class ProjectPageViewControllerDataSourceTests: XCTestCase {
|> \.extendedProjectProperties .~ ExtendedProjectProperties(
environmentalCommitments: [],
faqs: [],
aiDisclosure: nil,
risks: "",
story: self.storyViewableElements,
minimumPledgeAmount: 1
Expand Down
4 changes: 3 additions & 1 deletion Kickstarter-iOS/Features/ProjectPage/Views/ProjectNavigationSelectorView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,10 @@ final class ProjectNavigationSelectorView: UIView {
sectionIndex = 2
case .risks:
sectionIndex = 3
case .environmentalCommitments:
case .aiDisclosure:
sectionIndex = 4
case .environmentalCommitments:
sectionIndex = 5
}

let navigationButton = UIButton()
Expand Down