[MBL-943] Add Additional Header Support to HTML Parser #1844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π² What
There's been a change on the web to support a new parser called
CKEditor
and it supports additional header tags. Previously we supported onlyh1
. Now we supporth1
,h2
,h3
,h4
,h5
,h6
.π€ Why
As stated above, we would eventually need to add new elements/HTML tags supported by more modern project creation tools.
π How
Pretty straightforward, taking a look at the Android pull request that does the exact same thing. Used the font sizes for reference so they should be the same size on both platforms.
Might be nice to screenshot test all the supported HTML components one day...thinking when we remove the parser and get good support for
story
properties on theProjectFragment
we can look into this.π See
β Acceptance criteria
h1
headers are larger size after the change. Before this change they were size20
, now they are28
. Ie. WakeFX Rope-Pal - Automated Waksurf Rope System on staging. (screens above).h3
andh4
would not show. HTML snippet from sample project:<h3 id=\"h:Header\" class=\"page-anchor\">Header</h3><h4 id=\"h:Subheader\" class=\"page-anchor\">Subheader</h4>
, but now they do. (screens above)β° TODO