[MBL-960] Fix crash by using default hashing and equality for the config #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1850 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 1276 1276
Lines 116026 116017 -9
Branches 30892 30888 -4
=======================================
- Hits 98155 98149 -6
+ Misses 16788 16786 -2
+ Partials 1083 1082 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
msadoon
approved these changes
Sep 6, 2023
Library/Format.swift
Outdated
| @@ -403,7 +403,7 @@ public enum Format { | |||
|
|
|||
| public let defaultThresholdInDays = 30 // days | |||
|
|
|||
| internal struct DateFormatterConfig { | |||
| internal struct DateFormatterConfig: Hashable, Equatable { | |||
There was a problem hiding this comment.
Cool, yea let's do this - according to the documentation - Hashable conformance requires Equatable, so you probably only need Hashable.
https://developer.apple.com/documentation/swift/hashable
There was a problem hiding this comment.
Cool, I'll delete the explicit Equatable. Thanks!
scottkicks
approved these changes
Sep 6, 2023
ifosli
force-pushed
the
dateFormatCrash
branch
from
2c669bc
to
939482b
Compare
ifosli
force-pushed
the
dateFormatCrash
branch
from
939482b
to
924181b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Update the date formatter to conform to
HashableandEquatableby default instead of having custom implementations. This has the effect of also relying on thedateFormatwhen comparing twoDateFormatterConfigobjects.Also add a test that fails without these changes and passes now that the caching is fixed.
🤔 Why
Currently, when the
dateFormatis ignored in comparisons, when we try to parse a different date format, we fetch a cached one expecting a different format, leading to a crash. This happens any time we try to create a formatter for a config that has a different date format but is otherwise identical to a formatter that's already been cached. Specifically, this happens when we show the creator tools deprecation banner and also show credit card expiration dates without killing the app in-between.👀 See
JIRA ticket
✅ Acceptance criteria