Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-975] Report This Project Feature Flag #1851

Merged
merged 1 commit into from Sep 13, 2023
Merged

Conversation

scottkicks
Copy link
Contributor

📲 What

A new Feature Flag for the Report This Project feature

🤔 Why

Even though this new feature will be released as enabled 100%, in order to appease Apple's UGC guideline, it's still better to have one in case of emergency.

🛠 How

Added to RemoteConfigFeatures, RemoteConfigFeature+Helpers, RemoteConfigFeatureFlagToolsViewModel.

report_this_project was also added to our RemoteConfig Dashboard on Firebase. Production, Beta and Alpha.

👀 See

Trello, screenshots, external resources?

Before 🐛 After 🦋
Screenshot 2023-09-12 at 11 48 35 AM Screenshot 2023-09-12 at 11 48 45 AM

✅ Acceptance criteria

  • Feature flag is available for use via a helper method.

@scottkicks scottkicks self-assigned this Sep 12, 2023
@scottkicks scottkicks added this to the release-5.11.0 milestone Sep 12, 2023
@scottkicks scottkicks marked this pull request as ready for review September 12, 2023 17:40
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #1851 (6b92f87) into main (24e0c7b) will decrease coverage by 0.01%.
The diff coverage is 74.07%.

@@            Coverage Diff             @@
##             main    #1851      +/-   ##
==========================================
- Coverage   84.06%   84.06%   -0.01%     
==========================================
  Files        1280     1280              
  Lines      116769   116796      +27     
  Branches    31019    31035      +16     
==========================================
+ Hits        98162    98180      +18     
- Misses      17525    17533       +8     
- Partials     1082     1083       +1     
Files Changed Coverage Δ
Library/RemoteConfig/RemoteConfigFeature.swift 0.00% <0.00%> (ø)
...Models/RemoteConfigFeatureFlagToolsViewModel.swift 69.13% <37.50%> (-3.47%) ⬇️
...ary/RemoteConfig/RemoteConfigFeature+Helpers.swift 80.00% <80.00%> (ø)
...oteConfigFeatureFlagToolsViewControllerTests.swift 100.00% <100.00%> (ø)
...emoteConfig/RemoteConfigFeature+HelpersTests.swift 100.00% <100.00%> (ø)
...s/RemoteConfigFeatureFlagToolsViewModelTests.swift 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@scottkicks scottkicks merged commit aaf8e72 into main Sep 13, 2023
6 checks passed
@scottkicks scottkicks deleted the report-this-project-ff branch September 13, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants