Strings latest 001 #186
Merged
Strings latest 001 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinswart
approved these changes
Jun 22, 2017
|
@justinswart yes just a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updated to our latest strings and revised screenshots.
Why
It's been a while and this will help trim down PRs in the works that need new strings, but have to update unrelated screenshot tests along with them.
one caveat
We lost some of the French translation in the Discovery "Saved" empty state because it was removed from
en.ymlfor another PR. I reverted it, but the French still needs to propagate again. That does mean a couple screenshots will need to update again soon.