Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INF-1630] use m1 resource class #1862

Merged
merged 3 commits into from Oct 5, 2023
Merged

Conversation

talaris
Copy link
Member

@talaris talaris commented Oct 4, 2023

馃摬 What

Updates the CircleCI config to use the M1 resources instead of x86.

  • Additionally, at the moment Apollo only targets x86 so this also installs Rosetta in CI

馃 Why

CircleCI is retiring the MacOS x86 resource types.

馃憖 See

Also note there is a performance improvement, but also a cost increase with moving to M1. The cost is ~2x the x86 cost.

Before 馃悰 After 馃 What
avg 55 min 31 min Total build time

@talaris talaris requested review from ifosli, scottkicks and a team October 4, 2023 19:10
@talaris talaris changed the title Inf 1630/use m1 resource class [INF-1630] use m1 resource class Oct 4, 2023
@amy-at-kickstarter
Copy link
Contributor

@talaris It looks like there might be an extra commit pulled in here (cfed005)

@talaris
Copy link
Member Author

talaris commented Oct 4, 2023

I believe that was pushed onto the branch to try and fix the apollo errors. I can rebase it out if we don't want it.

@talaris talaris self-assigned this Oct 4, 2023
@amy-at-kickstarter
Copy link
Contributor

@talaris Whoops, you're right! Pardon me 馃槄

Copy link
Contributor

@ifosli ifosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, can confirm that the graphql changes did fix some warnings (that we thought might be related to the error but weren't). So not strictly necessary in this PR, but definitely still a plus. Thanks for updating this for us!

@talaris talaris merged commit f857029 into main Oct 5, 2023
6 checks passed
@talaris talaris deleted the inf-1630/use-m1-resource-class branch October 5, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants