Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-978] Remove creator dashboard button #1864

Merged
merged 1 commit into from Oct 10, 2023
Merged

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Oct 5, 2023

๐Ÿ“ฒ What

Remove button that allows a creator to navigate from the project page of a project they own to the dashboard.

๐Ÿ‘€ See

JIRA

Before ๐Ÿ› After ๐Ÿฆ‹
image image

โœ… Acceptance criteria

  • Log into a creator account and open the project page for a project they own. Ex "Help me transform this pile of wood" by therealnativesquad@gmail.com. Make sure "You launched this project..." banner still shows, but doesn't have a "View progress" or "View dashboard" button

TODO

  • Wait for initial remove creator dashboard pr to be submitted before this

@ifosli ifosli added the bug label Oct 5, 2023
@ifosli ifosli self-assigned this Oct 5, 2023
@ifosli ifosli added this to the release-5.12.0 milestone Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1864 (2643f31) into main (b06f4b1) will decrease coverage by 3.97%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1864      +/-   ##
==========================================
- Coverage   87.93%   83.97%   -3.97%     
==========================================
  Files         855     1219     +364     
  Lines       76748   110963   +34215     
  Branches    20294    29463    +9169     
==========================================
+ Hits        67492    93180   +25688     
- Misses       8519    16772    +8253     
- Partials      737     1011     +274     
Files Coverage ฮ”
...ectPage/Controller/ProjectPageViewController.swift 50.94% <รธ> (รธ)
Library/ViewModels/ProjectPageViewModel.swift 96.99% <รธ> (+0.51%) โฌ†๏ธ
...ls/ProjectPamphletCreatorHeaderCellViewModel.swift 100.00% <รธ> (รธ)
...ojectPamphletCreatorHeaderCellViewModelTests.swift 100.00% <รธ> (รธ)
...Views/Cells/ProjectPamphletCreatorHeaderCell.swift 0.00% <0.00%> (รธ)

... and 366 files with indirect coverage changes

๐Ÿ“ฃ Weโ€™re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿงน ๐Ÿ‘

@ifosli ifosli merged commit ebec1e8 into main Oct 10, 2023
6 checks passed
@ifosli ifosli deleted the youLaunchedThisProjectBanner branch October 10, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants