Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-957] Add RichPushNotifications push service extension to supportrich push notifications with Braze #1882

Merged
merged 7 commits into from
Nov 28, 2023
Merged

[MBL-957] Add RichPushNotifications push service extension to supportrich push notifications with Braze #1882

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4dd76b0
[MBL-957] Add RichPushNotifications push service extension to support…
amy-at-kickstarter Nov 7, 2023
84f6b55
Set up com.kickstarter.kickstarter.debug.RichPushNotifications certif…
amy-at-kickstarter Nov 20, 2023
eab8fcc
Add RichPushNotification target identifiers for beta, kickalpha and e…
amy-at-kickstarter Nov 27, 2023
4153759
Set provisioning profiles for RichPushNotifications for kickalpha and…
amy-at-kickstarter Nov 28, 2023
69fd7f2
Set provisioning profile for RichPushNotifications for release
amy-at-kickstarter Nov 28, 2023
7c1c2a8
Merge branch 'main' into feat/adyer/mbl-967/rich-push
amy-at-kickstarter Nov 28, 2023
c801d6a
Merge branch 'main' into feat/adyer/mbl-967/rich-push
amy-at-kickstarter Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ platform :ios do
private_lane :match_development do
match(
app_identifier: [
"com.kickstarter.kickstarter.debug"
"com.kickstarter.kickstarter.debug",
"com.kickstarter.kickstarter.debug.RichPushNotifications"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Before we ship this, I need to make this change for the Enterprise and App Store targets. But I wanted to get a sign-off from either @ifosli or @scottkicks before I do it - since I'll have to run/update our fastlane certs to do so. I'm fine doing that for the dev target, but want to make sure I don't bury us in certificate problems by doing it for the other app targets!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline and decided that we should have enough time during this sprint to address any certificate issues that come up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Yeah my plan is to do the other upgrades on Monday so I've got a full week of (non-Holiday) runway if someone goes haywire

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

],
type: "development",
git_url: "git@github.com:kickstarter/ios-certificates",
Expand Down