Refresh comments when a user is blocked #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1886 +/- ##
==========================================
- Coverage 83.75% 83.74% -0.01%
==========================================
Files 1222 1222
Lines 111429 111444 +15
Branches 29638 29644 +6
==========================================
+ Hits 93323 93325 +2
- Misses 17089 17102 +13
Partials 1017 1017 ☔ View full report in Codecov by Sentry. |
| @@ -166,14 +172,16 @@ final class CommentRepliesViewController: UITableViewController, MessageBannerVi | |||
| self.viewModel.outputs.userBlocked | |||
| .observeForUI() | |||
| .observeValues { [weak self] success in | |||
| self?.commentComposer.isHidden = true | |||
| guard let self else { return } | |||
There was a problem hiding this comment.
Huh, nice shortcut. Didn't know you could do that 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
If a user is blocked, comments are reset - refetched and the user is jumped back to top. If a user is blocked from the
CommentRepliesViewController, they're navigated back to the mainCommentsViewController.Note: I did consider refetching comments in place instead, but getting it to work with pagination seemed tricky, so I'm clearing state instead for now. If we have time, it would be nice to revisit this approach and try to let the user keep their place in our comments.
👀 See
Jira
✅ Acceptance criteria