Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO TICKET] Update Block User Strings #1889

Merged
merged 2 commits into from Nov 28, 2023
Merged

[NO TICKET] Update Block User Strings #1889

merged 2 commits into from Nov 28, 2023

Conversation

scottkicks
Copy link
Contributor

📲 What

Pull in translated strings and use them in the block user flow.

✅ Acceptance criteria

  • All strings in the user block flow still work as intended

@scottkicks scottkicks self-assigned this Nov 27, 2023
@scottkicks scottkicks added this to the release-5.11.0 milestone Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4d76071) 83.74% compared to head (8a115b1) 83.74%.

Files Patch % Lines
Library/UIAlertController.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1889   +/-   ##
=======================================
  Coverage   83.74%   83.74%           
=======================================
  Files        1222     1222           
  Lines      111440   111440           
  Branches    29644    29644           
=======================================
  Hits        93324    93324           
  Misses      17099    17099           
  Partials     1017     1017           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottkicks scottkicks merged commit e1e5d68 into main Nov 28, 2023
6 checks passed
@scottkicks scottkicks deleted the scott/update-strings branch November 28, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants