MBL-1074: Disable Github annotations in .codecov.yml #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
==========================================
- Coverage 83.74% 83.74% -0.01%
==========================================
Files 1226 1226
Lines 111767 111767
Branches 29725 29725
==========================================
- Hits 93598 93596 -2
- Misses 17152 17154 +2
Partials 1017 1017 ☔ View full report in Codecov by Sentry. |
amy-at-kickstarter
force-pushed
the
feature/adyer/mbl-1074-working
branch
from
39268fb
to
0d65cb8
Compare
scottkicks
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Disable inline annotations from Codecov in Github PRs.
🤔 Why
The team agreed that these annotations are more annoying than they are helpful. While they can be disabled easily in Github, it's a small distraction we don't need.
The same coverage information is still posted in the Codecov summary in the PR.
👀 See
Here's an example of this change in action: #1898
You'll note that there are complaints in the Codecov summary, but not inline.