Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1120] Post Campaign Pledge Feature Flag #1917

Merged
merged 3 commits into from Jan 19, 2024

Conversation

scottkicks
Copy link
Contributor

πŸ“² What

A new Feature Flag for the post campaign pledging.

πŸ›  How

  • Updated RemoteConfigFeatures, RemoteConfigFeature+Helpers, RemoteConfigFeatureFlagToolsViewModel.
  • Added tests

post_campaign_pledge flag was also added to our Firebase RemoteConfig Dashboard Production, Beta and Alpha apps.

πŸ‘€ See

Screenshot 2023-09-12 at 11 48 35 AM

βœ… Acceptance criteria

  • Feature flag is available for use via the featurePostCampaignPledgeEnabled() helper method.
  • Feature flag is available in our Firebase RemoteConfig Dashboard
  • Updating the flag from our Firebase dashboard updates the app
  • We can update the app locally. This change persists and takes priority over the Firebase dashboard flag value. This is for internal testing.

@scottkicks scottkicks self-assigned this Jan 19, 2024
@scottkicks scottkicks added this to the release 5.13.0 milestone Jan 19, 2024
@scottkicks scottkicks marked this pull request as ready for review January 19, 2024 16:48
@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c294ec4) 83.75% compared to head (97f5a2d) 83.74%.

Files Patch % Lines
...Models/RemoteConfigFeatureFlagToolsViewModel.swift 37.50% 5 Missing ⚠️
...ary/RemoteConfig/RemoteConfigFeature+Helpers.swift 80.00% 0 Missing and 1 partial ⚠️
Library/RemoteConfig/RemoteConfigFeature.swift 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1917      +/-   ##
==========================================
- Coverage   83.75%   83.74%   -0.01%     
==========================================
  Files        1229     1229              
  Lines      112161   112188      +27     
  Branches    29853    29869      +16     
==========================================
+ Hits        93937    93955      +18     
- Misses      17196    17204       +8     
- Partials     1028     1029       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@scottkicks scottkicks merged commit 70bd65c into main Jan 19, 2024
5 checks passed
@scottkicks scottkicks deleted the scott/post-campaign-pledge-ff branch January 19, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants