Move CombineTestObserver files to the test target #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
force-pushed
the
combineTestObserverCrash
branch
from
24434be
to
5fa1d71
Compare
ifosli
changed the title
|
I created a follow-up ticket to create a shared test target: https://kickstarter.atlassian.net/browse/MBL-1179 |
amy-at-kickstarter
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Thanks for catching this and the quick fix! I'm a little surprised none of our tests fail in a "crashes-on-launch" scenario - I guess none of them actually boot the app? Might be worth adding an integration test that launches the app for unfortunate scenarios like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Move combineTestObserver to all test targets and its corresponding test to the
KsApiTeststarget. Otherwise, the app crashes on launch.I think there's probably a better way to ensure
combineTestObserveris accessible to all test targets without being accessible outside of tests, but I think that would involve creating a separate target just for it, and I'm not sure if that's worth it.✅ Acceptance criteria