Make RemoteConfigFeatureFlagToolsViewModelTests resistant to adding new features #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
force-pushed
the
feat/adyer/cleaner-feature-flags-pt-2
branch
from
91b2b99
to
9cda6c4
Compare
| ] | ||
|
|
||
| for feature in RemoteConfigFeature.allCases { | ||
| let trueOrFalse = feature.rawValue.hashValue % 2 == 1 |
There was a problem hiding this comment.
This is so each flag will get a stable true or false value, but we don't have to keep adding them to this list.
ifosli
approved these changes
Feb 1, 2024
scottkicks
approved these changes
Feb 5, 2024
amy-at-kickstarter
force-pushed
the
feat/adyer/cleaner-feature-flags-pt-2
branch
from
9cda6c4
to
ba6bbef
Compare
amy-at-kickstarter
force-pushed
the
feat/adyer/cleaner-feature-flags-pt-2
branch
from
ba6bbef
to
0712545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
This is a follow up to my PR #1924, making one more test future-proof.
🤔 Why
Adding feature flags is unnecessarily difficult, requiring a lot of copy-paste. This is one more place we shouldn't have to paste a new flag.