Stub controller for logging in with OAuth #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1158/login-controller-stub
branch
from
06ce422
to
856d19c
Compare
| @@ -3067,7 +3068,7 @@ | |||
| E1BB25632B1E81AA000BD2D6 /* Publisher+Service.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Publisher+Service.swift"; sourceTree = "<group>"; }; | |||
| E1EA34EE2AE1B28400942A04 /* Signal+Combine.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Signal+Combine.swift"; sourceTree = "<group>"; }; | |||
| E1EEED282B684AA7009976D9 /* PKCE.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PKCE.swift; sourceTree = "<group>"; }; | |||
| E1EEED2A2B686829009976D9 /* PKCETest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; name = PKCETest.swift; path = KsApi/PKCETest.swift; sourceTree = "<group>"; }; | |||
| E1EEED2A2B686829009976D9 /* PKCETest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PKCETest.swift; sourceTree = "<group>"; }; | |||
There was a problem hiding this comment.
This was just kind of floating at the top of the project navigator; small change to fix it.
ifosli
approved these changes
Feb 1, 2024
scottkicks
reviewed
Feb 5, 2024
|
|
||
| extension LoginToutViewController: ASWebAuthenticationPresentationContextProviding { | ||
| public func presentationAnchor(for _: ASWebAuthenticationSession) -> ASPresentationAnchor { | ||
| return self.view.window! |
There was a problem hiding this comment.
Might be a good idea to unwrap this. Though, I'm don't think it's likely that window will be nil at this point
There was a problem hiding this comment.
Will do. Agreed, but perhaps better safe than sorry in this case.
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1158/login-controller-stub
branch
from
07b6c38
to
dc9db9b
Compare
amy-at-kickstarter
deleted the
feat/adyer/MBL-1158/login-controller-stub
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
This is the initial/stubbed version of the login controller, just to allow us to test the entire flow. Note that the login page (and the redirect) aren't pushed on the web yet.
I've marked additional obvious work with
//TODOs, plus, we'll need to re-jigger the sign-up flow as well. But this is a good start!🤔 Why
This is part of the larger project to move our app login to OAuth.
👀 See
Logging.in.mp4
📓 Please note
This needs to merge after the feature flag PR, #1928. You can ignore that commit in here.