Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1146] Update transcend privacy url to use current locale #1932

Merged
merged 2 commits into from Feb 6, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Feb 5, 2024

📲 What

Update the url to use the language code for the current locale. We're doing this instead of a translatable string because this is how they construct urls on web, so they explicitly ask translators to not translate urls.

👀 See

JIRA

✅ Acceptance criteria

  • Url (request my data or delete my account button) opens the modal in the app language for all the languages we support

@ifosli ifosli self-assigned this Feb 5, 2024
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, but there's a gotcha - your phone can be in any language, and we don't support every single language code on the Kickstarter web side. (For an example: Arabic is ar but https://legal.kickstarter.com/policies/ar/ is a 404.) Can we either fix it on the client or server side so that this link always (at least) goes to a valid default page, instead of a 404?

I'm also just a little confused about the behavior here, has this web page been translated? Ones I expect to work - es or de - still show the page 99% in English.

@ifosli
Copy link
Contributor Author

ifosli commented Feb 5, 2024

This makes sense, but there's a gotcha - your phone can be in any language, and we don't support every single language code on the Kickstarter web side. (For an example: Arabic is ar but https://legal.kickstarter.com/policies/ar/ is a 404.) Can we either fix it on the client or server side so that this link always (at least) goes to a valid default page, instead of a 404?

I'm also just a little confused about the behavior here, has this web page been translated? Ones I expect to work - es or de - still show the page 99% in English.

There's a reason I wanted to do this with translations instead... I did check what happens if your phone is in a language we don't support and the locale that apple gives us is the locale of the app not the phone default. And then I checked all the languages that our app supports and they all open the modal in the corresponding language.

The "take control" modal is translated into the different languages (ex: https://legal.kickstarter.com/policies/es/?modal=take-control) so even though the policies aren't translated, I still think it's worth using the localized url.

Interestingly enough, I also checked what happens if we provide a language code that isn't supported and the modal still opens (in english) - it's just the policy it renders on top of that doesn't show. This will not happen unless we change the languages we support, but it's not a worst-case scenario if it does.

@amy-at-kickstarter
Copy link
Contributor

I did check what happens if your phone is in a language we don't support and the locale that apple gives us is the locale of the app not the phone default. And then I checked all the languages that our app supports and they all open the modal in the corresponding language.

Aha! This isn't what I expected/remembered. Sounds fine to me then.

Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swapping to approved after discussion

@ifosli ifosli merged commit 44c8f14 into main Feb 6, 2024
5 checks passed
@ifosli ifosli deleted the transcendPrivacyUrlUpdate branch February 6, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants