Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-1196] Add post campaign bool to the reward fragment #1934

Merged
merged 6 commits into from Feb 7, 2024
Merged

[MBL-1196] Add post campaign bool to the reward fragment #1934

merged 6 commits into from Feb 7, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Feb 6, 2024 •
edited

📲 What

Update the reward fragment to include post campaign backing info. Also updates the related Reward class.

👀 See

Jira

✅ Acceptance criteria

  • Rewards UX is unchanged

⏰ TODO

  • Wait until fix for server error is deployed to prod before submitting (currently rewards look normal in staging but not in prod

@ifosli ifosli self-assigned this Feb 6, 2024
@ifosli ifosli changed the title Add post campaign bool to the reward fragment [MBL-1122] Add post campaign bool to the reward fragment Feb 7, 2024
@ifosli ifosli changed the title [MBL-1122] Add post campaign bool to the reward fragment [MBL-1196] Add post campaign bool to the reward fragment Feb 7, 2024
@ifosli ifosli marked this pull request as ready for review February 7, 2024 16:34
amy-at-kickstarter
amy-at-kickstarter approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ifosli ifosli merged commit 9dd3062 into main Feb 7, 2024
5 checks passed
@ifosli ifosli deleted the postCampaignFragment branch February 7, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-at-kickstarter amy-at-kickstarter amy-at-kickstarter approved these changes

@scottkicks scottkicks Awaiting requested review from scottkicks

Assignees

@ifosli ifosli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ifosli @amy-at-kickstarter