MBL-1158: Set up correct URLs for OAuth authorization endpoint #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
requested review from
scottkicks,
Arkariang and
santiDotIO
| // TODO: MBL-1159: Get required information from the callback; call mutation to login. | ||
| } | ||
|
|
||
| if featureLoginWithOAuthEnabled(), let session = OAuth.createAuthorizationSession() { |
There was a problem hiding this comment.
Moving this into the OAuth struct, I don't think we'll need any logic to live in LoginToutViewController.
| return session | ||
|
|
||
| } catch { | ||
| // TODO: Is there a way we can log/monitor these errors? |
There was a problem hiding this comment.
@scottkicks Do we have a method for log generic errors in iOS? In this case, I only expect this catch to happen if something really odd occurs, i.e. we fail to create a URL from a hardcoded string, or are unable to generate a hash.
There was a problem hiding this comment.
Added this to our iOS sync agenda.
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1158/auth-urls
branch
from
9653d70
to
e9e3bad
Compare
ifosli
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
This sets up the actual authorization URLs we will be using for OAuth, instead of the previous placeholder.
馃 Why
Now that the web change is live, we can start testing!