Add a nonfatal error; delete another nonfatal error #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Crashlytics.crashlytics().record(error: remoteConfigActivationError) | ||
| if errorAsNSError.domain == RemoteConfigErrorDomain, | ||
| errorAsNSError.code == RemoteConfigError.internalError.rawValue { |
There was a problem hiding this comment.
Dug a bit into the Firebase code - this is the correct domain and error for what they're sending us (error 8003). The naming is a bit confusing, so it's possible we'll accidentally catch an error we may have been interested in.
There was a problem hiding this comment.
cc @ifosli since you disliked this error!
scottkicks
approved these changes
Feb 13, 2024
amy-at-kickstarter
force-pushed
the
feat/adyer/nonfatal-logging-add-one-delete-one
branch
from
477afad
to
00d7023
Compare
amy-at-kickstarter
deleted the
feat/adyer/nonfatal-logging-add-one-delete-one
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
🤔 Why
This is to take better advantage of our non-fatal error logging in Crashlytics. Removing a noisy error, adding one I care about.