Explicitly add Prelude to Link Libraries phase of Kickstarter-Framework #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
force-pushed
the
feat/adyer/tinker-with-linker
branch
from
7a2382c
to
f42ec83
Compare
amy-at-kickstarter
force-pushed
the
feat/adyer/tinker-with-linker
branch
from
f42ec83
to
ba9edca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
Explicitly link Prelude as part of the build phases for Kickstarter-Framework.
馃 Why
One of our more persistent (and annoying) build issues is this linker error, in which it fails to link to Prelude:
My best guess (based on a little reading and this helpful StackOverflow post) is that Xcode is sometimes clever enough to resolve these dependencies automatically, but not consistently. Note that for our other targets, we also have libraries (including Prelude) explicitly linked, so it seems probable that this was just an omission.
Adding this resolved that particular instance of that Prelude linker error that was I was seeing. Hopefully this reduces the overall number of linker errors we get on a regular basis.