Remove old legacyOauthToken code (from 2016) #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
force-pushed
the
feat/adyer/remove-legacy-oauth-token
branch
from
9f09a5e
to
735ce1d
Compare
SwiftFormat found issues:
Generated by 🚫 Danger |
ifosli
approved these changes
Feb 15, 2024
amy-at-kickstarter
force-pushed
the
feat/adyer/remove-legacy-oauth-token
branch
from
d1a1148
to
62ac189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Remove a switch in the code that checks for a legacy OAuth token.
🤔 Why
As part of OAuth (or as a fast follow), we're going to swap the apps over to save our OAuth tokens in the keychain. I noticed while poking around our login code that we have this very, very old migration. I look at the commit 9e53ab9 where this was added, and it was back in 2016. If I'm reading our tags right, it was shipped around version 3.0.2, which is so old it's not even tracked in Firebase.
I think it's resoundingly safe to delete this, and it will make the code cleaner when we add a new migration for the new way to store OAuth tokens.
Worst case scenario is that someone upgrading from a truly ancient version of the app will have to log in again. 🤷♀️
✔️ TODO