[MBL-1207] Pledge Button on Project Page #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkicks
force-pushed
the
mbl-1207-pcp-project-page-button
branch
2 times, most recently
from
dec8fbe
to
60ebf16
Compare
scottkicks
force-pushed
the
mbl-1207-pcp-project-page-button
branch
from
60ebf16
to
8147602
Compare
scottkicks
force-pushed
the
mbl-1207-pcp-project-page-button
branch
from
8147602
to
7cd834a
Compare
ifosli
requested changes
Feb 20, 2024
There was a problem hiding this comment.
I like where this is headed, but I have some concerns. I've left comments. Also, I'm confused about this line: "If the user has already backed it, they'll see the normal "View Rewards" CTA" - if a user has backed a thing, they shouldn't see a "view rewards" CTA - they should see a "view your pledge" button. Can you make sure you test this scenario, if you haven't already?
ifosli
approved these changes
Feb 21, 2024
| case (.successful, .errored): | ||
| case (.successful, _, true): | ||
| return .viewBacking | ||
| case (.successful, .errored, _): |
There was a problem hiding this comment.
I could be wrong here, but I think a user could have an errored backing even if the project is in a post campaign state. If that's the case, we'd want to check the errored case first, in which case I don't think we actually need any custom post campaign logic at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this applies to PCP campaigns that backers have already pledged to
📲 What
Updates the pledge button on project pages to say "Back this project" when a campaign has Post-Campaign Pledging (PCP) enabled and is actively accepting late pledges.
In addition, I also made sure that the correct pledge button shows on rewards when in a PCP state. Right now, if a project isn't live or has already been backed, we don't show anything. Now, the pledge button will show when in an active PCP state if the user hasn't already backed.
If the user has already backed it, they'll see the normal "view your pledge" CTA that presents users with their pledge info.
🤔 Why
If PCP is disabled and a user has backed the campaign, we show a “View Rewards” button. For this feature, we want backers to be able to pledge post a successful campaign. It's important to note that backers should never be able to pledge more than once to any campaign
🛠 How
Let’s use the feature flag and the new PCP properties on the project fragment to gate this new behavior.
👀 See
Designs
✅ Acceptance criteria