MBL-1233: Consolidate login and signup buttons when OAuth is enabled #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
requested review from
a team and
scottkicks
and removed request for
a team
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1233/consolidate-signup-and-login-buttons
branch
2 times, most recently
from
898c661
to
6bdaad5
Compare
|
|
||
| /// True if the feature flag for OAuth login is true. | ||
| /// Note that this is not a signal, because we don't want it to ever change after the screen is loaded. | ||
| var loginWithOAuthEnabled: Bool { get } |
There was a problem hiding this comment.
This is perhaps a bit of a paranoid move, but since login is something you might do right after launch, I didn't want there to ever be a situation where the remote config reloads after the login screen has already been presented.
This way, this property is set when the view controller is initialized, and never changes.
| Strings.login_tout_back_intent_traditional_login_button() | ||
| } | ||
| if self.viewModel.outputs.loginWithOAuthEnabled { | ||
| // TODO: Add and translate a new version of this string for this page. |
There was a problem hiding this comment.
This will be a separate web PR + a follow-up to this PR once the strings are finished.
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1233/consolidate-signup-and-login-buttons
branch
from
6bdaad5
to
9251263
Compare
scottkicks
approved these changes
Feb 26, 2024
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1233/consolidate-signup-and-login-buttons
branch
from
9251263
to
ab726c8
Compare
amy-at-kickstarter
deleted the
feat/adyer/MBL-1233/consolidate-signup-and-login-buttons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
Remove the sign up button (and change the login button text) when OAuth is turned on.
馃 Why
Users who want to sign up will go through the web-based sign up flow, using the same web view as login.
馃憖 See
OAuth off:
OAuth on:
