Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1221] Update graphql-schema to prepare for attribution #1958

Merged
merged 4 commits into from Feb 26, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Feb 23, 2024

📲 What

Run bin/apollo-schema-download.sh and update the validate checkout mutation to align with changes.

I decided to do this in a separate pr from the event attribution mutation creation since updating the graphql-schema caused me to need to fix the build.

Note: this is pre-work for https://kickstarter.atlassian.net/browse/MBL-1221

✅ Acceptance criteria

  • Build still works

@ifosli ifosli self-assigned this Feb 23, 2024
@ifosli
Copy link
Contributor Author

ifosli commented Feb 23, 2024

@scottkicks I think this is an uneventful change since I don't think this mutation is actually being used yet, but it might affect your work. Let me know if you'd rather own this or if there's anything else I should test before merging this.

@ifosli ifosli changed the title Update schema for attribution [MBL-1221] Update schema for attribution Feb 23, 2024
@ifosli ifosli changed the title [MBL-1221] Update schema for attribution [MBL-1221] Update graphql-schema to prepare for attribution Feb 23, 2024
Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation of the new PCP related mutations haven't been started so this is fine.

@ifosli ifosli merged commit 2d47d34 into main Feb 26, 2024
5 checks passed
@ifosli ifosli deleted the updateSchemaForAttribution branch February 26, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants