[MBL-1223] Track attribution event #1961
Merged
+89
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
requested review from
a team and
amy-at-kickstarter
and removed request for
a team
| props["context_page_url"] = contextPageUrl ?? "" | ||
|
|
||
| let propsData = try? JSONSerialization.data(withJSONObject: props) | ||
| return String(data: propsData!, encoding: .utf8) |
There was a problem hiding this comment.
Is the force unwrap here necessary? Looks like the function already returns String? so it seems like you could just test for propsData and return nil if needed.
There was a problem hiding this comment.
Good catch! I like to force unwrap things when I'm testing but I didn't mean to leave it in. Fixed.
amy-at-kickstarter
approved these changes
Feb 28, 2024
scottkicks
added a commit
that referenced
this pull request
Mar 11, 2024
commit ac31c78 Merge: 547a64c 0dadd81 Author: Scott Clampet <110618242+scottkicks@users.noreply.github.com> Date: Mon Mar 11 09:41:19 2024 -0500 Merge branch 'main' into scott/pcp/initial-confirm-details-controller commit 0dadd81 Author: Amy <a.dyer@kickstarter.com> Date: Thu Mar 7 11:04:17 2024 -0500 Add tracking event for logins/signups that happen via OAuth commit 547a64c Merge: 134bcf3 2c8286c Author: Scott Clampet <110618242+scottkicks@users.noreply.github.com> Date: Thu Mar 7 08:54:18 2024 -0600 Merge branch 'main' into scott/pcp/initial-confirm-details-controller commit 2c8286c Author: Ingerid Fosli <i.fosli@kickstarter.com> Date: Wed Mar 6 11:53:04 2024 -0700 [MBL-1223] Track attribution event (#1961) * Track attribution event * Return nil instead of force unwrapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Create an event attribution tracking event the first time a project page loads. This will ensure the event is sent only once per project (since we create a new view model when we configure the view controller with a new project).
Note that we can't simply send the event when the view model is configured, since we need the graphQL id of the project, which we don't have until the fresh project fetch completes.
👀 See
Jira
Spike
✅ Acceptance criteria