Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1234: 馃槈 #1964

Merged
merged 2 commits into from Feb 29, 2024
Merged

Conversation

amy-at-kickstarter
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter commented Feb 28, 2024

馃摬 What

IYKYK 馃槈

@@ -19,8 +19,7 @@ extension Service {

return Service.session.rac_dataResponse(
preparedRequest(forURL: URL, method: properties.method, query: properties.query),
uploading: properties.file.map { ($1, $0.rawValue) },
and: self.perimeterXClient
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ErrorHandler was only ever used for PerimeterX.

@amy-at-kickstarter amy-at-kickstarter changed the title MBL-1234: Delete PerimeterX from codebase MBL-1234: 馃槈 Feb 28, 2024
@amy-at-kickstarter amy-at-kickstarter force-pushed the feat/adyer/MBL-1234/deprecate-perimeterx branch from 6d34a8e to 85c1ee3 Compare February 28, 2024 17:26
@nativeksr
Copy link
Collaborator

nativeksr commented Feb 28, 2024

SwiftFormat found issues:

File Rules
KsApi/ServiceTypeTests.swift:325:1 warning: (wrap) Wrap lines that exceed the specified maximum width.
Library/AppEnvironment.swift:466:1 warning: (wrap) Wrap lines that exceed the specified maximum width.
Library/AppEnvironment.swift:467:1 warning: (wrap) Wrap lines that exceed the specified maximum width.
Library/AppEnvironment.swift:468:1 warning: (wrap) Wrap lines that exceed the specified maximum width.

Generated by 馃毇 Danger

@amy-at-kickstarter amy-at-kickstarter marked this pull request as ready for review February 28, 2024 17:59
@amy-at-kickstarter amy-at-kickstarter requested review from a team, scottkicks and Arkariang and removed request for a team February 28, 2024 17:59
@amy-at-kickstarter amy-at-kickstarter force-pushed the feat/adyer/MBL-1234/deprecate-perimeterx branch from 85c1ee3 to 28d70c4 Compare February 29, 2024 15:16
@amy-at-kickstarter amy-at-kickstarter merged commit bfa07f7 into main Feb 29, 2024
5 checks passed
@amy-at-kickstarter amy-at-kickstarter deleted the feat/adyer/MBL-1234/deprecate-perimeterx branch February 29, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants