MBL-1211: Pass down pledge total to thank you page for new page copy #1965
+42
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| self.backedProjectText = self.configureWithDataProperty.signal | ||
| .skipNil() | ||
| .map { project, _, _, _ in |
There was a problem hiding this comment.
Fourth arg here will be the pledge total once I update the strings.
There was a problem hiding this comment.
Is the plan to then gate the string from within this output?
There was a problem hiding this comment.
@scottkicks Correct; this is just plumbing to get all the data where it needs to go.
amy-at-kickstarter
changed the title
|
Whoops, converting to draft while I fix tests. |
| @@ -905,7 +905,7 @@ public class PledgeViewModel: PledgeViewModelType, PledgeViewModelInputs, Pledge | |||
| isApplePay: isApplePay | |||
| ) | |||
|
|
|||
| return (data.project, baseReward, checkoutPropsData) | |||
| return (data.project, baseReward, checkoutPropsData, data.pledgeTotal) | |||
There was a problem hiding this comment.
One line to change it, another 40 lines to fix the tests about it 😆
scottkicks
requested changes
Mar 5, 2024
scottkicks
approved these changes
Mar 5, 2024
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1211/pledge-total-plumbing
branch
from
5e62280
to
fa0fbce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Pass the pledge total into the thank you page.
🤔 Why
The new string for post-campaign backings on the thank-you page will reference the pledge amount, so we need it in the view model.