MBL-1211: Rewire current user email in AppEnvironment/AppDelegateViewModel #1966
+37
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fix
AppEnvironment.current.currentUserEmail
, which did not appear to be correctly saving the currently logged-in user's e-mail.🤔 Why
We need the user's e-mail on the Thanks page for post-campaign backings. I noticed that we had this
currentUserEmail
property onEnvironment
, but it wasn't working correctly. I did some digging and I figured it's because the signal is being deallocated before the value is set.An interesting question is why
currentUserEmail
isn't just part ofcurrentUser
. Apparently the V1User
object doesn't appear to have an e-mail attached to it, and the e-mail is coming from GraphQL, instead. It's a bit messy but I wanted to keep this change fairly low-profile instead of doing more refactoring.